-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to distort an image with 4 corner points (perspective distortion) #299
Comments
It would be helpful for alignment purposes if the opacity of the top layer could be reduced while adjusting the alignment. |
For sure! Leaflet DistortableImage has that menu option, and we can try to
preserve it in this adaptation.
…On Thu, Jun 28, 2018 at 12:07 PM pahenry ***@***.***> wrote:
It would be helpful for alignment purposes if the opacity of the top layer
could be reduced while adjusting the alignment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#299 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ22VAJOICDVwtNVPWNHpQG8tRD0xks5uBP8pgaJpZM4U6Uss>
.
|
Can I please work on this issue? |
That'd be great!
…On Sat, Jan 5, 2019, 6:42 AM Slytherin ***@***.*** wrote:
Can I please work on this issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#299 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ9pJgb3xYWNv_XFBinHnvIKKMBFPks5vAI-IgaJpZM4U6Uss>
.
|
@jywarren can you please provide some more details into it . |
Added some insights in an update above; this'll depend on #216 -- I think we should try to make a minimal module first based on webgl-distort, which wouldn't need to try to integrate the whole Leaflet codebase. Make sense? |
We'll need to refactor webgl-distort to not interact with the HTML DOM, so restructuring it to work with an Image object instead of an image element, in this line: We should be able to support the original usage too, but make a new core module that can be used within image-sequencer. What do you think? |
@jywarren Can you provide use case or any more information , as I was thinking of doing this. Any information about your expectations |
Ah, this will be the interface for
#64 ! Does that help?
…On Sat, Jan 26, 2019 at 1:15 PM Slytherin ***@***.***> wrote:
@jywarren <https://github.com/jywarren> can you please provide some more
details into it .
I went through https://github.com/publiclab/Leaflet.DistortableImage
<http://url> and was not able to judge the working .
Can you please provide some insights?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#299 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ6q5l4tMPV_TZGHYXNwjZesTFmVsks5vHJsOgaJpZM4U6Uss>
.
|
Yeah it helps, I was thinking of adding this to my proposal but for now I had left it as I didn't have information, so if you could please go through my proposal and let me know your review it would be really great, |
https://github.com/publiclab/Leaflet.DistortableImage allows distortion of images using 4 points, in the browser.
(https://github.com/jywarren/webgl-distort produces a distorted image and could be integrated as a webgl-only module -- see #64)
We could implement this kind of "drag four corners" interface as an HTML UI, backed with a distortion library.
This issue would have 3 parts:
x, y
for each cornerblend
module)See this demo: https://publiclab.github.io/Leaflet.DistortableImage/examples/select
This would be helpful in getting 2 images which aren't an exact overlay match to line up, so that they can be used to generate NDVI: https://publiclab.org/notes/warren/12-24-2010/ndvi-test-lima-peru
Update
This probably should use this module:
https://github.com/jywarren/webgl-distort
Or some variant of it. And to work in node, it'll depend on #216, webgl for node.
The UI could start with just a set of pixel coordinate parameters. We could later try to refactor in a more complete HTML UI as in Leaflet.DistortableImage as a follow-up!
The text was updated successfully, but these errors were encountered: