Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch on delete a sequence after crop #352

Closed
Paarmita opened this issue Sep 29, 2018 · 7 comments
Closed

Patch on delete a sequence after crop #352

Paarmita opened this issue Sep 29, 2018 · 7 comments
Labels

Comments

@Paarmita
Copy link
Member

There occurs a black patch when we delete the crop sequence.

Issue can be reproduced like this

aaa ogv

@gitmate
Copy link

gitmate bot commented Sep 29, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #351 (Image selector area in crop for the first sequence), #5 (image cropping module), #213 (Crop Module not working correctly), #292 (Crop Module changes in a sequencer are not persisting), and #229 (follow-up refinements to crop image selection UI).

1 similar comment
@gitmate
Copy link

gitmate bot commented Sep 29, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #351 (Image selector area in crop for the first sequence), #5 (image cropping module), #213 (Crop Module not working correctly), #292 (Crop Module changes in a sequencer are not persisting), and #229 (follow-up refinements to crop image selection UI).

@gitmate gitmate bot added the bug label Sep 29, 2018
@Ankit-Singla
Copy link

@tech4GT @jywarren Take a look at this. The patch stays until and unless a there is a click in the grey of the patch, and also renders the part of the UI it overlaps inaccessible/unresponsive.
Good observation @Paarmita
I would like to give it a try, if that's okay.

@Paarmita
Copy link
Member Author

Paarmita commented Oct 6, 2018

@Ankit-Singla Go for it 👍 You need to see the files to be changed for this bug.

@tech4GT
Copy link
Member

tech4GT commented Oct 6, 2018

@Ankit-Singla Actually I am aware of this issue and last I checked this was an issue with the library Image-area-select that we for the selection feature. Maybe you can solve some smaller issues first to familiarize yourself with the code a little more before diving into this one, what say? Thanks!

@Ankit-Singla
Copy link

Ankit-Singla commented Oct 6, 2018

Alright @tech4GT
In the meantime I'll also read more on the Image-area-select library. Thanks btw!

@vibhorgupta-gh
Copy link

vibhorgupta-gh commented Jan 1, 2019

@tech4GT @jywarren PR #590 resolves this. The fix is a workaround since the plugin itself is buggy. Upon observation, the divs with classes imgareaselect-* are the ones that always remained, so I added custom js to handle removing those divs from the DOM itself when the remove function is called. Works well for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants