-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes remnant div after removing crop step #590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share a gif of your work Vibhor, nice work! :)
Oh, i was going to rebuild this but I think actually the dist files are unrelated to your code! Would you mind just removing them from this PR? Thanks! |
@jywarren removing them as in? Do you mean rebasing changes? The changes made have to reflect in the dist files, so I don't get how they're unrelated... |
Actually the UI files aren't compiled into dist (yet) so I think these may be unrelated. Or perhaps I am confused? |
@jywarren Ah, I see. I'll open a fresh PR then. Removing files here is going to be messy. |
Fixes #352
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!