Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes remnant div after removing crop step #590

Closed
wants to merge 1 commit into from

Conversation

vibhorgupta-gh
Copy link

Fixes #352

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@vibhorgupta-gh
Copy link
Author

@jywarren @tech4GT is this an acceptable fix? Please review :)

Copy link
Member

@tech4GT tech4GT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share a gif of your work Vibhor, nice work! :)

@vibhorgupta-gh
Copy link
Author

vibhorgupta-gh commented Jan 3, 2019

crop

@vibhorgupta-gh
Copy link
Author

@jywarren @tech4GT here :)

@jywarren
Copy link
Member

jywarren commented Jan 4, 2019

Oh, i was going to rebuild this but I think actually the dist files are unrelated to your code! Would you mind just removing them from this PR? Thanks!

@vibhorgupta-gh
Copy link
Author

@jywarren removing them as in? Do you mean rebasing changes? The changes made have to reflect in the dist files, so I don't get how they're unrelated...

@jywarren
Copy link
Member

jywarren commented Jan 5, 2019

Actually the UI files aren't compiled into dist (yet) so I think these may be unrelated. Or perhaps I am confused?

@vibhorgupta-gh
Copy link
Author

@jywarren Ah, I see. I'll open a fresh PR then. Removing files here is going to be messy.

@vibhorgupta-gh vibhorgupta-gh deleted the crop branch January 6, 2019 20:13
@jywarren jywarren mentioned this pull request Jan 7, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants