Ability to set background color when "over cropping" to enlarge canvas

[jywarren]

When the crop module is given dimensions larger than the original image, it adds blank (transparent) pixels to the image edges; see this example:

http://sequencer.publiclab.org/examples/#steps=crop{x:0|y:0|w:611|h:479}

It would be excellent to offer as a parameter the color that can be filled instead of left blank. Here is the section of code where it's performed; perhaps we could tell if a pixel is outsider the original bounds and fill it with the given color?

image-sequencer/src/modules/Crop/Crop.js

Lines 12 to 21 in 4d996b9

	var ox = options.x;
	var oy = options.y;
	var w = options.w;
	var h = options.h;
	var iw = pixels.shape[0]; //Width of Original Image
	var newarray = new Uint8Array(4*w*h);
	for (var n = oy; n < oy + h; n++) {
	newarray.set(pixels.data.slice(n*4*iw + ox, n*4*iw + ox + 4*w),4*w*(n-oy));
	}
	pixels.data = newarray;

[gitmate]

GitMate.io thinks possibly related issues are #5 (image cropping module), #229 (follow-up refinements to crop image selection UI), and #352 (Patch on delete a sequence after crop).

[gitmate]

GitMate.io thinks possibly related issues are #5 (image cropping module), #229 (follow-up refinements to crop image selection UI), and #352 (Patch on delete a sequence after crop).

[JKusio]

It looks interesting! But how would we set the color? RGB, HEX, or color input?

Anyway, I'd like to work on that one 😅

[jywarren]

Cool, great! Yes, let's set the color for now via a hex value... could that work? Or shall we say an array like [r, g, b, a] to make an easier first step? Later, we might want to include some color conversion tools so you could use various methods of indicating a color.

…

On Mon, Nov 12, 2018 at 6:20 AM KusioDev ***@***.***> wrote: It looks interesting! But how would we set the color? RGB, HEX, or color input? Anyway, I'd like to work on that one 😅 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#467 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJwPULyM3AJdgvs3S8Lhuw02V57-bks5uuVlZgaJpZM4YY8Jf> .

[Mridul97]

@jywarren I would love to work on this!

[jywarren]

That'd be awesome!!!

…

On Tue, Dec 25, 2018, 3:02 PM Mridul97 ***@***.*** wrote: @jywarren <https://github.com/jywarren> I would love to work on this! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#467 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ006O34eMGhndpXKqgOpXKJlSb15ks5u8oQegaJpZM4YY8Jf> .