Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align box in center in mobile view #484

Closed
Paarmita opened this issue Nov 20, 2018 · 28 comments
Closed

Align box in center in mobile view #484

Paarmita opened this issue Nov 20, 2018 · 28 comments

Comments

@Paarmita
Copy link
Member

Paarmita commented Nov 20, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Problem:

We want the Download PNG and View GIF buttons div in the center in the mobile view.

How to Solve?

You can add responsiveness in the div.

This line can be added below this one.

<div style="text-align:center;">

Instance Count 1

screenshot from 2018-11-20 13-11-29

@gitmate
Copy link

gitmate bot commented Nov 20, 2018

GitMate.io thinks the contributors most likely able to help are @tech4GT, @SidharthBansal, and @GitMate[bot].

Possibly related issues are #355 (Adjust/Correct the position of Buttons in Mobile View), and #436 (Enhance gif view).

1 similar comment
@gitmate
Copy link

gitmate bot commented Nov 20, 2018

GitMate.io thinks the contributors most likely able to help are @tech4GT, @SidharthBansal, and @GitMate[bot].

Possibly related issues are #355 (Adjust/Correct the position of Buttons in Mobile View), and #436 (Enhance gif view).

@gitmate gitmate bot added the question label Nov 20, 2018
@jywarren
Copy link
Member

jywarren commented Nov 20, 2018 via email

@Rishabh570
Copy link

For anybody who would work on it, only removing this would made it sit in the center :)

@lwahlnayar
Copy link

Can I give it a go at this? I'm completely new to contributions =)

@Rishabh570
Copy link

@lwahlnayar Are you participating in GCI?

@lwahlnayar
Copy link

not really...

@Rishabh570
Copy link

Actually, this task is for GCI participants...I appreciate that you want to contribute, you can take a look at other open first-timer-only issues here: https://code.publiclab.org/

@lwahlnayar
Copy link

alright, thanks!

@jonxuxu
Copy link
Member

jonxuxu commented Nov 26, 2018

Hey there, could I work on this for GCI? This task doesn't seem to be available on the dashboard but I'm also not aware if someone else is working on it...

@Rishabh570
Copy link

Yes, you can work on it as it's not claimed by anybody yet...I've created a draft for it, pinging @jywarren for reviewing it and publishing it :)

@jonxuxu
Copy link
Member

jonxuxu commented Nov 27, 2018

@Rishabh570 great, I've centered the div in #502.

@jywarren
Copy link
Member

jywarren commented Nov 27, 2018 via email

@jonxuxu
Copy link
Member

jonxuxu commented Nov 28, 2018

Is there a link?

@Rishabh570
Copy link

@jonxuxu
Copy link
Member

jonxuxu commented Nov 28, 2018

Oh it seems like this is a beginner task. My bad.

@jywarren
Copy link
Member

jywarren commented Dec 2, 2018

Someone has claimed this in GCI and needs to post a pull request still. I requested more work, and we'll see if we hear back. Thanks everyone! 👍

@AmanGarg97
Copy link

Hey! Can I work on this? It's my first contribution on image-sequencer.

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jan 12, 2019

@AmanGarg97, sure! That will be awesome. But are you new to an issue like this? If you have solved such other issues before then you can leave this one for some first timer and solve some other one maybe?

@vibhorgupta-gh
Copy link

@AmanGarg97 I think you can take this one up since you are contributing to Image Sequencer for the first time, familiarise yourself with the code base.
@harshkhandeparkar I think this is a good fto issue, let's let first-timers work on this, cheers!

@harshkhandeparkar
Copy link
Member

@AmanGarg97 I think you can take this one up since you are contributing to Image Sequencer for the first time, familiarise yourself with the code base.
@harshkhandeparkar I think this is a good fto issue, let's let first-timers work on this, cheers!

What I felt was that someone like @AmanGarg97 can get acquainted with the codebase easily but someone a bit less experienced might take more time. So someone who is new to github and PRs etc. can take up this issue maybe? @VibhorCodecianGupta what do you say?

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jan 12, 2019

@VibhorCodecianGupta maybe @AmanGarg97 can take up an intermediate level issue maybe? This can be fixed too! @AmanGarg97 what do you want to do? Will you be able to fix something a bit more difficult than this? Or do you want to fix this? Welcome to the image-sequencer community 🎉 🎉

@AmanGarg97
Copy link

@VibhorCodecianGupta @harshkhandeparkar I can start with this but it would also be best if you can assign some another issue so that I can go through the codebase and can start contributing to this.
Thanks!

@AmanGarg97
Copy link

Hey please review #669 and let me know for any other changes.

@AmanGarg97
Copy link

Also are there any proper Contributions Guidelines for the project?
What I faced was:

  1. How to install the project in Linux environment for a newbie.
    2.What are the steps to solve an issue and make a PR (branching and all that stuff).

If there is not then I will love to make one.
Thanks!

@tech4GT
Copy link
Member

tech4GT commented Jan 13, 2019

I think we have a setup script Aman, try running npm run setup and then npm run start

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jan 27, 2019

@jywarren @gauravano @Paarmita I think this is not required due to recent changes

screenshot_20190127-110553

But there is a PR open for it #669

@grvsachdeva grvsachdeva removed the gci-candidate Issue being considered for gci label Jan 28, 2019
@grvsachdeva
Copy link
Member

Thanks @harshkhandeparkar for the update! Closing this issue for now, feel free to open if necessary. Thank you @AmanGarg97 for working on it, really appreciated 💯 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants