Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance gif view #436

Closed
adisapphire opened this issue Oct 22, 2018 · 6 comments
Closed

Enhance gif view #436

adisapphire opened this issue Oct 22, 2018 · 6 comments
Labels
enhancement gci-candidate Issue being considered for gci HTML medium

Comments

@adisapphire
Copy link
Member

adisapphire commented Oct 22, 2018

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

The Problem

Enhance gif view, Gif should show in popup view instead of it showing in same page.
some thing like this.
https://www.w3schools.com/bootstrap/bootstrap_modal.asp

The Solution

check this link
https://getbootstrap.com/docs/4.0/components/modal/
write html code here
https://github.com/publiclab/image-sequencer/blob/main/examples/index.html#L90
js if reqiured here


and css if required here
display: block;

Thanks
Instance Count = 1

@adisapphire adisapphire added enhancement gci-candidate Issue being considered for gci medium labels Oct 22, 2018
@SidharthBansal
Copy link
Member

Can you please tell code links in the repository?
So that I can publish this onto GCI main website.
We need to have code links in the issues before posting them onto GCI dashboard.
Thanks

@adisapphire
Copy link
Member Author

adisapphire commented Oct 22, 2018

yes sure in a moment
thanks

@adisapphire
Copy link
Member Author

adisapphire commented Oct 22, 2018

@SidharthBansal I think this can be pushable now onto gci dashboard
Thanks

@gitmate gitmate bot added the HTML label Oct 22, 2018
@gitmate
Copy link

gitmate bot commented Oct 22, 2018

GitMate.io thinks the contributors most likely able to help are @jywarren, and @tech4GT.

Possibly related issues are #344 (Add a function to create a gif from the outputs of all steps), #427 (Download and download as gif button not working in image sequencer), and #355 (Adjust/Correct the position of Buttons in Mobile View).

1 similar comment
@gitmate
Copy link

gitmate bot commented Oct 22, 2018

GitMate.io thinks the contributors most likely able to help are @jywarren, and @tech4GT.

Possibly related issues are #344 (Add a function to create a gif from the outputs of all steps), #427 (Download and download as gif button not working in image sequencer), and #355 (Adjust/Correct the position of Buttons in Mobile View).

@SidharthBansal
Copy link
Member

This task is published on GCI dashboard. Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement gci-candidate Issue being considered for gci HTML medium
Projects
None yet
Development

No branches or pull requests

2 participants