Show spinner icon while gif is generating

[tsparksh]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem

After clicking on "View GIF" while Gif is generating we can not see spinner icon.

📋Solution

• 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• 📝 Update the file examples/demo.js in the image-sequencer repository (press the little pen Icon) and edit the line as shown below.

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$('.js-view-as-gif').on('click', function(event) {
    // Prevent user from triggering generation multiple times
    if (isWorkingOnGifGeneration) return;

    isWorkingOnGifGeneration = true;

    var button = event.target;
    button.disabled = true;
+   button.innerHTML='<i class="fa fa-circle-o-notch fa-spin"></i>'

...

          button.disabled = false;
+         button.innerHTML='View GIF';
          isWorkingOnGifGeneration = false;
        }
      });
    }
    catch(e) {
      console.error(e);
      button.disabled = false;
+     button.innerHTML = 'View GIF';
      isWorkingOnGifGeneration = false;

    }
  });

• 💾 Commit your changes

• 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

[welcome]

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

[tsparksh]

#487

[gitmate]

GitMate.io thinks the contributors most likely able to help are @oorjitchowdhary, and @JonathanXu1.

Possibly related issues are #120 (Add spinner GIF overlays in demo while output generates), #436 (Enhance gif view), #211 (Make an icon for the project), and #471 (Change Gif to GIF in 'View Gif' button.).

[gitmate]

GitMate.io thinks the contributors most likely able to help are @oorjitchowdhary, and @JonathanXu1.

Possibly related issues are #120 (Add spinner GIF overlays in demo while output generates), #436 (Enhance gif view), #211 (Make an icon for the project), and #471 (Change Gif to GIF in 'View Gif' button.).

[grvsachdeva]

@publiclab/image-sequencer-guides please review the task details. Thanks!

[Rishabh570]

@thesparks It can be converted into a fto issue if you provide the DIFF of required changes...it will help a newcomer :)
Pinging @publiclab/image-sequencer-guides

[tsparksh]

@Rishabh570, Thank you! Is it okey now?

[Rishabh570]

@thesparks Looks good 🎉

[lohitha02]

I Would like to claim this issue.

[harshkhandeparkar]

Go ahead!