Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of UI tasks to be broken out into issues #487

Closed
15 of 17 tasks
jywarren opened this issue Nov 22, 2018 · 42 comments
Closed
15 of 17 tasks

List of UI tasks to be broken out into issues #487

jywarren opened this issue Nov 22, 2018 · 42 comments
Labels
bug gci-candidate Issue being considered for gci

Comments

@jywarren
Copy link
Member

jywarren commented Nov 22, 2018

Looking for help with these! They could also make good GCI issues @publiclab/mentors !

  • change "Save" module button to "Apply"
  • change description text above quick-add buttons so it stays as "apply a new step" instead of getting replaced by the last applied module's description (needs gif to demonstrate issue)
  • make Image Sequencer header reload the page with no steps
  • add a "start a new sequence" button somewhere in header
  • add "take a photo" as alternative to "Choose file" in initial load image step
  • move "Download PNG" box down onto same line as "Save Sequence" leaving Add Step box full-width
  • show spinner icon while gif is generating
  • Fix alignment of Add Step button and dropdown next to it
  • add toggle-able "collapse" button next to step name (like "load-image") to hide image, description (leaving just the line and the title)
  • add Resize module to list of quick buttons, as in this image

Sliders

  • make sliders (for range inputs) touch-draggable (using a library) - like brightness
  • set brightness default to not be totally white
  • set contrast default to something useful
  • set contrast to range slider UI

Save sequence

  • have "save sequence" also show a message showing where to find the saved sequence
  • have "save sequence" link to docs showing how to turn a sequence into a meta module
  • have "save sequence" link clarify that it will only be available in this browser
@gitmate
Copy link

gitmate bot commented Nov 22, 2018

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are #118 (Assorted improvements to be broken into separate issues), #165 (Various module ideas to be broken out into separate issues), #470 (UI Improvements ), #227 (PLANNING ISSUE), and #48 (A Semantic Issue).

1 similar comment
@gitmate
Copy link

gitmate bot commented Nov 22, 2018

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are #118 (Assorted improvements to be broken into separate issues), #165 (Various module ideas to be broken out into separate issues), #470 (UI Improvements ), #227 (PLANNING ISSUE), and #48 (A Semantic Issue).

@gitmate gitmate bot added the bug label Nov 22, 2018
@jywarren jywarren added the gci-candidate Issue being considered for gci label Nov 22, 2018
@Rishabh570
Copy link

@jywarren Opened this issue for changing "save" to "apply" in add step UI...

@jywarren
Copy link
Member Author

jywarren commented Nov 22, 2018 via email

@jywarren
Copy link
Member Author

jywarren commented Nov 22, 2018 via email

@Rishabh570
Copy link

@jywarren and they'll be getting credits/points for that?

@jywarren
Copy link
Member Author

jywarren commented Nov 22, 2018 via email

@aashna27
Copy link

added #491 for "set brightness default to not be totally white"

@aashna27
Copy link

should I continue with breaking up or leave it for gci task ?

@Rishabh570
Copy link

I think so, if they're well formatted! We could ask them to post a
screenshot and describe the feature a bit more. Not everyone will be able
to but some are pretty simple.

That would be great 👍

@oorjitchowdhary
Copy link
Member

@jywarren @Rishabh570 @aashna27 So is this a GCi task? I may be able to make these into well-formatted issues... We can also use the plots2 repo issue template

@Rishabh570
Copy link

Pinging @jywarren for that, you can make these into well formatted into issues...you can get credits/points for it :)

@oorjitchowdhary
Copy link
Member

So I can start working right?

@Rishabh570
Copy link

Rishabh570 commented Nov 25, 2018 via email

@oorjitchowdhary
Copy link
Member

oorjitchowdhary commented Nov 25, 2018

Added these till now... Pls take a look at them...

  1. add "take a photo" as alternative to "Choose file" in initial load image step Add 'Take a photo' as another option for initial load image step #494
  2. move "Download PNG" box down onto same line as "Save Sequence" leaving Add Step box full-width Move 'Download PNG' box on the same line as 'Save Sequence' #493
  3. add Resize module to list of quick buttons, as in this image Add the Resize module to the quick buttons bar #492

@oorjitchowdhary
Copy link
Member

Add some more #495 and #496

@oorjitchowdhary
Copy link
Member

Pls take a look and make a task on the gci dash so that i can claim it...
Also, I have to make issues for whole of the list right?

@Rishabh570
Copy link

Rishabh570 commented Nov 25, 2018 via email

@oorjitchowdhary
Copy link
Member

Ok so I'll be getting credits on the GCI platform right?

@oorjitchowdhary
Copy link
Member

Which is the task which is to be claimed here

@oorjitchowdhary
Copy link
Member

@jywarren @Rishabh570

@Rishabh570
Copy link

@oorjitchowdhary You can just create separate issues based on ideas suggested in the issue description and mention this issue if eligible you'll get credits for that...

@jywarren
Copy link
Member Author

@jonxuxu
Copy link
Member

jonxuxu commented Nov 26, 2018

Hey, I just claimed this task. Would you like me to make a separate issue for each bullet point?

@jywarren
Copy link
Member Author

jywarren commented Nov 26, 2018 via email

@jonxuxu
Copy link
Member

jonxuxu commented Nov 26, 2018

Here's an example: #498

Would you like it like this?

@jonxuxu
Copy link
Member

jonxuxu commented Nov 26, 2018

Alright, three's the charm :)
Submitted the task!

@jywarren
Copy link
Member Author

jywarren commented Nov 26, 2018 via email

@oorjitchowdhary
Copy link
Member

Added these till now... Pls take a look at them...

  1. add "take a photo" as alternative to "Choose file" in initial load image step Add 'Take a photo' as another option for initial load image step #494
  2. move "Download PNG" box down onto same line as "Save Sequence" leaving Add Step box full-width Move 'Download PNG' box on the same line as 'Save Sequence' #493
  3. add Resize module to list of quick buttons, as in this image Add the Resize module to the quick buttons bar #492

@jywarren @Rishabh570 I have claimed the task on GCI.. And as I mentioned I have already made 5 issues from this list.. So please approve my work at GCI..

@grvsachdeva
Copy link
Member

Hi @oorjitchowdhary, all issues looks good, please append the issue number in the checklist so that no-one else opens the same issue. Thanks!

@oorjitchowdhary
Copy link
Member

I have mentioned this issue in all of them..

@oorjitchowdhary
Copy link
Member

#492 #493 #494 #495 #496 all are opened up by me..

@grvsachdeva
Copy link
Member

screenshot from 2018-11-27 18-34-10

Mention after the above tasks in issue body.

@oorjitchowdhary
Copy link
Member

Looking for help with these! They could also make good GCI issues @publiclab/mentors !

  • change "Save" module button to "Apply"
  • change description text above quick-add buttons so it stays as "apply a new step" instead of getting replaced by the last applied module's description (needs gif to demonstrate issue)
  • make Image Sequencer header reload the page with no steps
  • add a "start a new sequence" button somewhere in header
  • add "take a photo" as alternative to "Choose file" in initial load image step
  • move "Download PNG" box down onto same line as "Save Sequence" leaving Add Step box full-width
  • show spinner icon while gif is generating
  • Fix alignment of Add Step button and dropdown next to it
  • add toggle-able "collapse" button next to step name (like "load-image") to hide image, description (leaving just the line and the title)
  • add Resize module to list of quick buttons, as in this image

Sliders

  • make sliders (for range inputs) touch-draggable (using a library) - like brightness
  • set brightness default to not be totally white
  • set contrast default to something useful
  • set contrast to range slider UI

Save sequence

  • have "save sequence" also show a message showing where to find the saved sequence
  • have "save sequence" link to docs showing how to turn a sequence into a meta module
  • have "save sequence" link clarify that it will only be available in this browser

You mean to checklist here.. I'm actually unable to edit that

@CodeSarthak
Copy link

Hey, I have made 3 separate issues: #513 #512 #511

@oorjitchowdhary
Copy link
Member

Hi @CodeSarthak.. I understand you are trying to complete this gci task.. But I've already opened some issues which you opened up too..

@oorjitchowdhary
Copy link
Member

#512 is the same as #494 opened by me
#513 is the same as #496
Pls open up different issues as duplication of issues leads to a lot of confusion...
Thanks 😃

@CodeSarthak
Copy link

Oh @oorjitchowdhary , really very sorry. Actually, I got confused because they were not checked in the checklist. Will pick up some others. : )

@jywarren
Copy link
Member Author

jywarren commented Jan 8, 2019

Wow I think these are all done!!! Amazing work, folks!

@jywarren jywarren closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug gci-candidate Issue being considered for gci
Projects
None yet
Development

No branches or pull requests

7 participants