Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the Save Sequence button until one step is added #453

Closed
wants to merge 4 commits into from
Closed

Disable the Save Sequence button until one step is added #453

wants to merge 4 commits into from

Conversation

Divy123
Copy link
Member

@Divy123 Divy123 commented Oct 30, 2018

Fixes #395

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Oct 30, 2018

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@Divy123 Divy123 changed the title Resolved issue #395 Disable the Save Sequence button until one step is added Oct 31, 2018
@Divy123
Copy link
Member Author

Divy123 commented Oct 31, 2018

@tech4GT please review.
Unable to tag @publiclab/reviewers .

@ho-dor
Copy link

ho-dor commented Nov 2, 2018

Can I work on this @Divy123 ?

@Divy123
Copy link
Member Author

Divy123 commented Nov 2, 2018

@ho-dor I have already created the PR for this. You may look forward to some other issue.

@jywarren
Copy link
Member

Hi! I was thinking, perhaps this could be more easily determined using sequencer.images.image1.steps.length ?

@Divy123 Divy123 closed this Nov 11, 2018
@Divy123
Copy link
Member Author

Divy123 commented Nov 11, 2018

Closing this pull request as I have committed wrong files by mistake.

@Divy123 Divy123 deleted the button-disable branch November 11, 2018 07:12
@jywarren
Copy link
Member

Ah, did this ever get resolved or re-opened? Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants