Disable the Save Sequence button until one step is added

[tech4GT]

First Timers Only

Hi, this is a first-timers-only issue. This means this has been worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Issue

The save-sequence button in the UI should be disabled until some step is added in the sequence.

Here's where the save-sequence button is made:

image-sequencer/examples/index.html

Line 99 in 9168c15

<button class="btn btn-primary btn-lg" name="save-sequence" id="save-seq">Save Sequence</button>

We can make the button disable at the start and then enable it on first click of Add step button. We have to also disable the button if all the steps are removed.

[tech4GT]

@jywarren Should we make this an FTO?

[gitmate]

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #303 (Disable/dim the Add step button until a module is selected), #302 (Disable/dim the Save button until step inputs have been changed), #342 (Add a success prompt for saved sequence), #377 (Module save button is sometimes greyed out when needed), and #363 (add placeholder when brightness step applied).

[gitmate]

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #303 (Disable/dim the Add step button until a module is selected), #302 (Disable/dim the Save button until step inputs have been changed), #342 (Add a success prompt for saved sequence), #377 (Module save button is sometimes greyed out when needed), and #363 (add placeholder when brightness step applied).

[jywarren]

Sure!!

…

On Sat, Oct 6, 2018, 7:54 PM gitmate[bot] ***@***.***> wrote: GitMate.io <https://gitmate.io> thinks the contributor most likely able to help you is @jywarren <https://github.com/jywarren>. Possibly related issues are #303 <#303> (Disable/dim the Add step button until a module is selected), #302 <#302> (Disable/dim the Save button until step inputs have been changed), #342 <#342> (Add a success prompt for saved sequence), #377 <#377> (Module save button is sometimes greyed out when needed), and #363 <#363> (add placeholder when brightness step applied). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#395 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJyBnNiYDtlR-T5TdI3hZXobTplCDks5uiJm3gaJpZM4XLUIv> .

[tech4GT]

@Mridul97 Could you format this into a first timers issue, much thanks!!

[Mridul97]

Done! Should we make it a gci-candidate issue?

[maciejmyslinski]

I'm on it.

[Divy123]

Is this issue still open?

[tech4GT]

@maciejmyslinski Are you still pursuing this one? If not @Divy123 can proceed with this. Thanks!

[Divy123]

@tech4GT I have taken up this issue as of now and started with the code base.

image-sequencer/src/InsertStep.js

Lines 39 to 41 in b30b539

	ref.modules[name].expandSteps = function expandSteps(stepsArray) {
	for (var step of stepsArray) {
	ref.addSteps(step['name'], step['options']);

Is this the array (stepsArray) the one with number of steps?

[tech4GT]

@Divy123 No you are looking in the wrong place, you need to look at the UI in examples folder and not the src.

[harshkhandeparkar]

This already works. Closing this one. 😊