Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize the Gif text on View Gif button #476

Merged
merged 1 commit into from
Nov 18, 2018

Conversation

Rishabh570
Copy link

Fixes #436

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Nov 17, 2018

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@Rishabh570
Copy link
Author

@publiclab/reviewers @Divy123 Please take a look...

@Divy123
Copy link
Member

Divy123 commented Nov 17, 2018

Thanks for the PR :). It looks good to me.
@jywarren please review.

@jywarren
Copy link
Member

👍 Thank you!!! We'd love more help from you if you're interested!

@jywarren jywarren merged commit ef10fb7 into publiclab:main Nov 18, 2018
@welcome
Copy link

welcome bot commented Nov 18, 2018

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://sequencer.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@Divy123
Copy link
Member

Divy123 commented Nov 19, 2018

@Rishabh570 you have mentioned the wrong issue number. Please correct it.
Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants