toggle-able collapse added for modules #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks awesome and I'm going to merge it. I'd like to suggest though that we come up with a slightly different style -- maybe using Bootstrap panels? https://getbootstrap.com/docs/3.3/components/#panels-heading In a follow-up issue. Would you like to open it? This way maybe they'd stack more nicely. Thanks, this is so great!!!! |
|
We could also duplicate the progress spinner into the panel header! |
|
So you can see it running even if it's closed... |
|
Great work @aashna27 !!! So exciting!!! |
|
This is an amazing idea 😄
…On Wed, Jan 9, 2019, 1:52 AM Jeffrey Warren ***@***.*** wrote:
So you can see it running even if it's closed...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#636 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZUPyAyylFanNwlFlyZZdAC4FEGyowFAks5vBP4igaJpZM4Z2BLH>
.
|
|
Yeahh sure I would follow up for it, noted 😊😊
…On Wed, Jan 9, 2019, 1:50 AM Jeffrey Warren ***@***.*** wrote:
This looks awesome and I'm going to merge it. I'd like to suggest though
that we come up with a slightly different style -- maybe using Bootstrap
panels?
https://getbootstrap.com/docs/3.3/components/#panels-heading
In a follow-up issue. Would you like to open it? This way maybe they'd
stack more nicely.
Thanks, this is so great!!!!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#636 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZUPyC8qk_N5muINXk-qes4vajnkuCN_ks5vBP2MgaJpZM4Z2BLH>
.
|
|
Awesome!
…On Tue, Jan 8, 2019 at 3:28 PM aashna27 ***@***.***> wrote:
This is an amazing idea 😄
On Wed, Jan 9, 2019, 1:52 AM Jeffrey Warren ***@***.***
wrote:
> So you can see it running even if it's closed...
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#636 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AZUPyAyylFanNwlFlyZZdAC4FEGyowFAks5vBP4igaJpZM4Z2BLH
>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#636 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ1TDqboNRdE-ieDECfyPAl-7nZSeks5vBP9LgaJpZM4Z2BLH>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowThanks!