Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle button next to step name #498

Closed
jonxuxu opened this issue Nov 26, 2018 · 10 comments
Closed

Add toggle button next to step name #498

jonxuxu opened this issue Nov 26, 2018 · 10 comments

Comments

@jonxuxu
Copy link
Member

jonxuxu commented Nov 26, 2018

This issue is a sub-issue of #487 , which is to be broken down into smaller issues.

So in the image-sequencer, each step has a config panel on the left, as shown below:
image

What we want to do is to add a toggle-able "collapse" button next to step name (like "load-image") to hide image, description (leaving just the line and the title), like shown in the Photoshop rendering below.

collapse

Please show us where to look

http://sequencer.publiclab.org/examples/#steps=

What's your PublicLab.org username?

JonathanXu1

Browser, version, and operating system

Firefox63, Windows 10


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@welcome
Copy link

welcome bot commented Nov 26, 2018

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@gitmate gitmate bot added the small label Nov 26, 2018
@gitmate
Copy link

gitmate bot commented Nov 26, 2018

GitMate.io thinks the contributor most likely able to help you is @oorjitchowdhary.

Possibly related issues are #466 (Add an "insert step" button on each step UI), #303 (Disable/dim the Add step button until a module is selected), #432 (display add step menu with common modules as "quick" buttons), #433 (display add step menu with common modules as "quick" buttons), and #496 (Add a 'Start a new sequence' button).

@gitmate
Copy link

gitmate bot commented Nov 26, 2018

GitMate.io thinks the contributor most likely able to help you is @oorjitchowdhary.

Possibly related issues are #466 (Add an "insert step" button on each step UI), #303 (Disable/dim the Add step button until a module is selected), #432 (display add step menu with common modules as "quick" buttons), #433 (display add step menu with common modules as "quick" buttons), and #496 (Add a 'Start a new sequence' button).

@gitmate gitmate bot added the enhancement label Nov 26, 2018
@jywarren
Copy link
Member

This looks great, but it could actually be a simpler caret icon too! We use Fontawesome, so maybe fa fa-caret?

@jywarren
Copy link
Member

And if a caret, it could go on the same line as the title!

@jonxuxu
Copy link
Member Author

jonxuxu commented Nov 26, 2018

That's a good idea too!

@kevinzluo
Copy link

I'd like to work on this.

@kevinzluo kevinzluo mentioned this issue Dec 6, 2018
4 tasks
@jonxuxu
Copy link
Member Author

jonxuxu commented Dec 6, 2018

@jywarren are all the sub tasks now available for codein?

@kevinzluo
Copy link

I think only the ones tagged with gci-candidate are available. I just did this task because I saw it last night and thought I could help out (though if anyone wants to give me credit I'm not complaining 😁). I am still waiting for this task to be added to the dashboard.

@jywarren
Copy link
Member

jywarren commented Dec 6, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants