Switch to yarn #677
Closed
Switch to yarn #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right_aws is no longer maintained, was throwing an error
render :text will be deprecated and poses a security risk
The test is failing because of different names in model(warpable) and controller(images) skipping this for now until we decide if we want to standardize the names
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| else | ||
| flash[:error] = 'You must be logged in to add tags' | ||
| redirect_to '/login?back_to=/maps/' + @map.slug | ||
| redirect_to "/login?back_to=/maps/#{@map.slug}" |
| @map.lon = params[:map][:lon] | ||
| @map.description = params[:map][:description] | ||
| @map.license = params[:map][:license] if @map.user_id == current_user.id | ||
| @map.update_attributes(map_params) |
| end | ||
| end | ||
|
|
||
| def update | ||
| @comment = Comment.find params[:id] | ||
| if logged_in? && current_user.can_edit?(@comment) | ||
| @comment.update_attribute(:body, params[:comment][:body]) | ||
| redirect_to '/maps/' + params[:map_id] | ||
| @comment.update_attributes(comment_params) |
| else | ||
| render 'new' | ||
| end | ||
| else | ||
| @map = Map.new(params[:map]) | ||
| @map = Map.new(map_params) |
|
Code Climate has analyzed commit 116f385 and detected 17 issues on this pull request. Here's the issue category breakdown:
Note: there are 8 critical issues. View more on Code Climate. |
|
Whoops wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351