Switch to yarn #678
Merged
Switch to yarn #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #678 +/- ##
============================================
Coverage 29.04% 29.04%
============================================
Files 34 34
Lines 1508 1508
============================================
Hits 438 438
Misses 1070 1070 |
|
@publiclab/mapknitter-reviewers Please review this. Thanks! |
jywarren
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
This looks good! Have you tried it out on the unstable server? Once this is merged, we can turn on Dependabot for JavaScript dependencies too!
https://app.dependabot.com/accounts/publiclab/projects/23423
5 tasks
alaxalves
reviewed
Jun 11, 2019
start.sh
Outdated
| @@ -3,7 +3,7 @@ | |||
| pidfile=/app/tmp/pids/server.pid | |||
|
|
|||
| bundle check || bundle install | |||
| bower install --allow-root | |||
| yarn install --allow-root | |||
There was a problem hiding this comment.
No there isn't. Removed it. Thanks 👍
|
Hi I've merged this to #669 and also published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351