Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in html tag (part of #10989) #11002

Closed
5 tasks
kachifako opened this issue Apr 9, 2022 · 22 comments · Fixed by #11096
Closed
5 tasks

Fix typo in html tag (part of #10989) #11002

kachifako opened this issue Apr 9, 2022 · 22 comments · Fixed by #11096
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@kachifako
Copy link
Contributor

💡Format this Issue Into a First Timers Issue

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting✍️, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled🏷. Or, if this is not your first time, try to solve it yourself🧑‍💻!


Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

  • 📝 Update these files in the plots2 repository (press the little pen Icon) and edit the lines as shown below:

  • 404.html (Line 62)

  • 422.html (Lines 45 and 63)

  • 500.html (Lines 43, 47, 65)

  • 502.html (Lines 46, 62)

  • 503.html (Lines 46, 62)

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

  -    <hr  />
  +     <hr>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

@kachifako kachifako added the fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet label Apr 9, 2022
@kachifako
Copy link
Contributor Author

I hope this is okay @TildaDares

@TildaDares
Copy link
Member

Looks good @kachifako. Thank you!!

@kachifako
Copy link
Contributor Author

Happy to be of help @TildaDares .

Should I assign the individual issues to first timers ?

@TildaDares
Copy link
Member

Reserved for @Crisoal for 24 hours!

@TildaDares TildaDares added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. and removed fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet labels Apr 9, 2022
@Crisoal
Copy link
Contributor

Crisoal commented Apr 9, 2022

thank you

Reserved for @Crisoal for 24 hours!

thank you

@Crisoal
Copy link
Contributor

Crisoal commented Apr 9, 2022

@TildaDares how do I make changes to the file?

@TildaDares
Copy link
Member

@Crisoal Have you gone through this issue's description?

@Crisoal
Copy link
Contributor

Crisoal commented Apr 10, 2022

@Crisoal Have you gone through this issue's description?

yes, but should I add my own words to the file?

@TildaDares
Copy link
Member

@Crisoal You are supposed to remove the lines that start with - and then replace it with the line that starts with +.

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

  -    <hr  />
  +     <hr>

@Crisoal
Copy link
Contributor

Crisoal commented Apr 10, 2022

@Crisoal You are supposed to remove the lines that start with - and then replace it with the line that starts with +.

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

  -    <hr  />
  +     <hr>

Yes, thank you. I got the hang of it and I have done the tasks

@kachifako
Copy link
Contributor Author

@Crisoal You are supposed to remove the lines that start with - and then replace it with the line that starts with +.

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

  -    <hr  />
  +     <hr>

Yes, thank you. I got the hang of it and I have done the tasks

did you create a pull request to merge the changes @Crisoal ?

@guyinmanhattan2021
Copy link

Hi @kachifako can I contribute to this?

@TildaDares
Copy link
Member

Hi @Crisoal, do you need help with this?

@haydenmlh
Copy link

Hi, I'd like to try this!

@Crisoal
Copy link
Contributor

Crisoal commented Apr 20, 2022

Hi @Crisoal, do you need help with this?

I have done the first task but I am not sure how to go about the second task. I edited the file by copying the code and creating another file. Is that right?

@TildaDares
Copy link
Member

@Crisoal What is the second task?

@Crisoal
Copy link
Contributor

Crisoal commented Apr 20, 2022

@Crisoal What is the second task?

it is to pull request

@TildaDares
Copy link
Member

@Crisoal You can follow this guide https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github. Skip the steps you’ve already done.

@Crisoal
Copy link
Contributor

Crisoal commented Apr 20, 2022

@Crisoal You can follow this guide https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github. Skip the steps you’ve already done.

ok, thanks

@Crisoal
Copy link
Contributor

Crisoal commented Apr 21, 2022

I have been able to pull a request. Can you pls review it?

@Crisoal
Copy link
Contributor

Crisoal commented Apr 21, 2022

I have been able to pull a request. Can you pls review it?

https://github.com/Crisoal/plots2

@TildaDares TildaDares linked a pull request Apr 21, 2022 that will close this issue
5 tasks
@Crisoal
Copy link
Contributor

Crisoal commented Apr 22, 2022

hello @TildaDares can you pls review what I did?

@TildaDares TildaDares linked a pull request Apr 22, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants