-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in html tag #11096
Fix typo in html tag #11096
Conversation
changed <hr/> to <hr> tag in lines 45 and 63
changed <hr/> to <hr> tag in lines 43, 47, and 63
changed <hr/> to <hr> tag in lines 46 and 62
changed <hr/> to <hr> tag in lines 46 and 62
Code Climate has analyzed commit 99ad2e4 and detected 0 issues on this pull request. View more on Code Climate. |
@TildaDares can you pls review what i have done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Crisoal! Great job.
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
I really your guidance and help in completing this task. Thank you. |
Is this regarded as a contribution? |
@Crisoal Yes this counts as a contribution. |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Congratulations @Crisoal 🎉 |
Fixes #0000
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below