Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in html tag #11096

Merged
merged 5 commits into from
Apr 22, 2022
Merged

Fix typo in html tag #11096

merged 5 commits into from
Apr 22, 2022

Conversation

Crisoal
Copy link
Contributor

@Crisoal Crisoal commented Apr 22, 2022

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

changed <hr/> to <hr> tag in lines 45 and 63
changed <hr/> to <hr> tag in lines 43, 47, and 63
changed <hr/> to <hr> tag in lines 46 and 62
changed <hr/> to <hr> tag in lines 46 and 62
@gitpod-io
Copy link

gitpod-io bot commented Apr 22, 2022

@codeclimate
Copy link

codeclimate bot commented Apr 22, 2022

Code Climate has analyzed commit 99ad2e4 and detected 0 issues on this pull request.

View more on Code Climate.

@Crisoal
Copy link
Contributor Author

Crisoal commented Apr 22, 2022

@TildaDares can you pls review what i have done?

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Crisoal! Great job.

@TildaDares TildaDares linked an issue Apr 22, 2022 that may be closed by this pull request
5 tasks
@TildaDares TildaDares changed the title updated Patch 6: changed <hr/> to <hr> tag Fix typo in html tag Apr 22, 2022
@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6220626115/artifacts/220203628

@Crisoal
Copy link
Contributor Author

Crisoal commented Apr 22, 2022

Thanks @Crisoal! Great job.

I really your guidance and help in completing this task. Thank you.

@Crisoal
Copy link
Contributor Author

Crisoal commented Apr 22, 2022

Is this regarded as a contribution?

@TildaDares
Copy link
Member

@Crisoal Yes this counts as a contribution.

@TildaDares
Copy link
Member

@Crisoal You can close #11090 and #11092 now.

@TildaDares TildaDares merged commit e211e63 into publiclab:main Apr 22, 2022
@welcome
Copy link

welcome bot commented Apr 22, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@TildaDares
Copy link
Member

Congratulations @Crisoal 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typo in html tag (part of #10989)
2 participants