-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed the <hr/> tags to <hr> tag #11090
Conversation
I updated line 62. I changed <hr/> to <hr>
I updated lines 45 and 63 Changed tag <hr/> to <hr>
I updated lines 43, 47 and 65 Changed <hr/> to <hr>
Updated lines 46 and 62 Changed <hr/> to <hr>
Updated lines 46 and 62 Changed <hr/> to <hr>
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 855eb09 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the code and created another file, then I changed the line |
Hi @Crisoal, you don't need to create a new file. All you have to do is go to the existing files and change the lines requested. Thanks! |
i wasn't able to edit the files |
@Crisoal Do you have a local env for this repo? |
i am not sure |
@Crisoal Navigate to this link https://github.com/publiclab/plots2/edit/main/public/404.html and change line 62 to |
okay, thanks |
@TildaDares pls, could you pls review what i have done? |
Fixes #0000
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below