Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the <hr/> tags to <hr> tag #11090

Closed
wants to merge 5 commits into from
Closed

Conversation

Crisoal
Copy link
Contributor

@Crisoal Crisoal commented Apr 21, 2022

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

I updated line 62. 

I changed <hr/> to <hr>
I updated lines 45 and 63

Changed tag <hr/> to <hr>
I updated lines 43, 47 and 65

Changed <hr/> to <hr>
Updated lines 46 and 62

Changed <hr/> to <hr>
Updated lines 46 and 62

Changed <hr/> to <hr>
@welcome
Copy link

welcome bot commented Apr 21, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Apr 21, 2022

@codeclimate
Copy link

codeclimate bot commented Apr 21, 2022

Code Climate has analyzed commit 855eb09 and detected 0 issues on this pull request.

View more on Code Climate.

@TildaDares TildaDares linked an issue Apr 21, 2022 that may be closed by this pull request
5 tasks
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Crisoal, it looks like you changed the entire file. You were only supposed to change a few lines in each file

404.html (Line 62)

422.html (Lines 45 and 63)

500.html (Lines 43, 47, 65)

502.html (Lines 46, 62)

503.html (Lines 46, 62)

@Crisoal
Copy link
Contributor Author

Crisoal commented Apr 21, 2022

Hi @Crisoal, it looks like you changed the entire file. You were only supposed to change a few lines in each file

404.html (Line 62)
422.html (Lines 45 and 63)
500.html (Lines 43, 47, 65)
502.html (Lines 46, 62)
503.html (Lines 46, 62)

I copied the code and created another file, then I changed the line

@TildaDares
Copy link
Member

TildaDares commented Apr 21, 2022

Hi @Crisoal, you don't need to create a new file. All you have to do is go to the existing files and change the lines requested. Thanks!

@Crisoal
Copy link
Contributor Author

Crisoal commented Apr 22, 2022

Hi @Crisoal, you don't need to create a new file. All you have to do is go to the existing files and change the lines requested. Thanks!

i wasn't able to edit the files

@TildaDares
Copy link
Member

@Crisoal Do you have a local env for this repo?

@Crisoal
Copy link
Contributor Author

Crisoal commented Apr 22, 2022

@Crisoal Do you have a local env for this repo?

i am not sure

@TildaDares
Copy link
Member

@Crisoal Navigate to this link https://github.com/publiclab/plots2/edit/main/public/404.html and change line 62 to <hr>. After doing that click the propose changes button.

@Crisoal
Copy link
Contributor Author

Crisoal commented Apr 22, 2022

@Crisoal Navigate to this link https://github.com/publiclab/plots2/edit/main/public/404.html and change line 62 to <hr>. After doing that click the propose changes button.

okay, thanks

@Crisoal
Copy link
Contributor Author

Crisoal commented Apr 22, 2022

@TildaDares pls, could you pls review what i have done?

@TildaDares TildaDares mentioned this pull request Apr 22, 2022
5 tasks
@Crisoal Crisoal closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typo in html tag (part of #10989)
2 participants