-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Email Validation #1996
Comments
@SidharthBansal I would like to do this :) |
Awesome!!! Go ahead! |
Solving in #1999 -- thank you! (just linking over there) |
@SidharthBansal I see that the issue is still open and hasn't been resolved yet. I would like to give it a try if I may. |
I think that @Paarmita left out. You can for sure try to resolve the issue |
@SidharthBansal Is someone working on the issue. I could see it is still open. Can I take this? |
@balaaagi I am really sorry for such a late reply. |
Claiming the issue as i dont see anyone working on it |
Great |
Changes as proposed by publiclab#1996
Closes publiclab#1996
@SidharthBansal i have done the changes as said but the checks does not pass.I further read about it |
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
Please describe the problem
A user is able to sign in and use publiclab with email wrong email addresses say bansal@gmail
📋 Step by Step
🙋♀️ Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Add VALID_EMAIL_REGEX = /\A[\w+-.]+@[a-z\d-.]+.[a-z]+\z/i to the
plots2/app/models/user.rb
Line 16 in 3b09a35
💾 Commit your changes
🔀 Start a Pull Request.
🏁 Done Ask in comments for a review :)
🤔❓ Questions?
Leave a comment below!
We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
Thank you!
Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.
The text was updated successfully, but these errors were encountered: