Update user.rb #2504
Update user.rb #2504
Conversation
Closes publiclab#1996
|
@namanjain1812 thanks for the pr. |
| @@ -13,6 +13,7 @@ class User < ActiveRecord::Base | |||
|
|
|||
| acts_as_authentic do |c| | |||
| c.openid_required_fields = %i(nickname email) | |||
| VALID_EMAIL_REGEX = /\A[\w+-.]+@[a-z\d-.]+.[a-z]+\z/i | |||
There was a problem hiding this comment.
Please add the regex expression into
c.validates_format_of_email_field_options = { with: /@/ }
also we had a discussion about regex in other pr, please have a look at it.
Please refer rubular for regex.
|
@namanjain1812 oh I see you closed the pr. You can submit the changes into an existing branch. No need to close the pr and open a new one. |
|
am closing this pr and making a final new one. Thanks for the help @SidharthBansal i figured out what to do. |
|
It would be great if we have one pr for one issue so that we can quickly see what discussion went previously. Hence, I will encourage you to make changes in the same pr. |
Closes #1996
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!