Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile page UI/UX inconsistencies #2173

Closed
6 of 8 tasks
SidharthBansal opened this issue Jan 30, 2018 · 16 comments
Closed
6 of 8 tasks

Profile page UI/UX inconsistencies #2173

SidharthBansal opened this issue Jan 30, 2018 · 16 comments
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration design issue requires more design work and discussion (i.e. mockups and sketches) help wanted requires help by anyone willing to contribute

Comments

@SidharthBansal
Copy link
Member

SidharthBansal commented Jan 30, 2018

Please describe the problem (or idea)

The tabs on /profile/author have different treatment in terms of

  • Some have count while others dont have

  • Some have icons while other

  • Some have text while other does not

  • Like tab should render liked pages on the same page but is rendering on the different page

  • Two horizontal lines on the bottom of profile page
    image

  • Broken Ajax ---> See carefully ....The pagination is in accordance with the maximum number of elements present in any of one tab

  • Go to comments nav bar. Then go on second page of comments. You will notice a new page to be opened instead of ajax.

  • A non logged in user can click on the tags to delete them
    image

What happened just before the problem occurred? Or what problem could this idea solve?
1)Either all should have count or none should
2)Same as 1
3)All should have text
4)Like should render the liked pages there also
5)One horizontal line
6)Pagination should be separately involved with each of the tabs
7)Only the creater should get the js prompt

@SidharthBansal
Copy link
Member Author

@ViditChitkara thanks for solving 3rd issue in this via #2166

@ViditChitkara
Copy link
Member

👍

@SidharthBansal SidharthBansal self-assigned this Jan 30, 2018
@SidharthBansal SidharthBansal added more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem won't fix labels Jan 30, 2018
@SidharthBansal SidharthBansal removed their assignment Feb 2, 2018
@SidharthBansal
Copy link
Member Author

@ebarry, @jywarren what do you suggest?

@SidharthBansal SidharthBansal added break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration in-progress and removed more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem won't fix labels Feb 6, 2018
@SidharthBansal SidharthBansal changed the title [Discussion]Similar button treatment of profile tabs Similar button treatment of profile tabs Feb 7, 2018
@SidharthBansal
Copy link
Member Author

@ViditChitkara thanks for opening #2262 and doing #2263.
@ViditChitkara Please notify me if you are working on some part of the issue. I was done with the counts on profile page but you pushed the changes so that others will not work on it.

@SidharthBansal
Copy link
Member Author

@jywarren is anyone else working on remaining parts of these sub issues?

@ViditChitkara
Copy link
Member

@SidharthBansal I didn't really had an idea that you were working on it. I just saw an untidy navbar while browsing on the mobile site and sent a patch for the same. Had I known someone was working on it, I would have been more than happy. Will take care about this in the future

@ViditChitkara ViditChitkara reopened this Feb 7, 2018
@SidharthBansal SidharthBansal changed the title Similar button treatment of profile tabs Profile page UI/UX inconsistencies Feb 7, 2018
@SidharthBansal
Copy link
Member Author

No problem, btw great catch.

@SidharthBansal
Copy link
Member Author

#2294 is also a part of profile pages

@jywarren jywarren added help wanted requires help by anyone willing to contribute design issue requires more design work and discussion (i.e. mockups and sketches) labels Jun 8, 2018
@jywarren jywarren added this to the User interface (UI) milestone Jun 8, 2018
@jywarren
Copy link
Member

jywarren commented Aug 3, 2018

Is this one perhaps complete? Or anything remaining could be broken out as a narrower issue? Thanks!!!

@SidharthBansal
Copy link
Member Author

One issue is left. Broken ajax.

@jywarren
Copy link
Member

jywarren commented Aug 4, 2018 via email

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Aug 5, 2018

Follow the following sequence

  1. Go to profile page
  2. Click the Like nav bar
  3. Click on 19 page from paginations given at the bottom
  4. You will be redirected to the Research nav bar and 19th page.
    Also, on the main welcome page also. When you switch over events from all events, etc. Refer Pagination broken at /research #2258.
    Does this makes sense?
    I tried to debug this error. But the solution did not work.
    Solution is https://gist.github.com/jeroenr/3142686 or similar post. I remember very well that I tried almost 9-10 solutions similar to this post. But they did not work out. So this subissue was not resolved. Sorry for lingering for this error.
    One more issue has arisen on profile page --> Once you will go to comments nav bar. Then go to the second page of comments. You will notice a new page to be opened instead of Ajax.
    I have added this into the checklist.

@jywarren
Copy link
Member

jywarren commented Aug 6, 2018 via email

@digitaldina
Copy link
Collaborator

digitaldina commented Dec 21, 2018

Hey! I was going to open and issues about this, and this issue showed up as related. So I thought I might talk about it here. I went to go edit my profile, when I noticed that the prompt to add an image is below editing your bio and all that, which isn't very intuitive for users. Also, the header "bio" should be above the box where you edit your bio. I'm using the latest version of Firefox if that helps. We might even be able to make this a first-timers-only issue! (if the issue ends up being a quick fix)
screenshot from 2018-12-20 21-23-13
screenshot from 2018-12-20 21-21-25

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Dec 21, 2018 via email

@jywarren
Copy link
Member

Profile pages are fully rebooted!!! Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration design issue requires more design work and discussion (i.e. mockups and sketches) help wanted requires help by anyone willing to contribute
Projects
None yet
Development

No branches or pull requests

4 participants