Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination broken at /research #2258

Open
SidharthBansal opened this issue Feb 6, 2018 · 22 comments
Open

Pagination broken at /research #2258

SidharthBansal opened this issue Feb 6, 2018 · 22 comments
Assignees
Labels
help wanted requires help by anyone willing to contribute JavaScript Ruby

Comments

@SidharthBansal
Copy link
Member

The pagination is in accordance to the research section always. It does not change to the events section pagination on clicking on the events.
image
Eventhough we have only 3 events it showed us n pages because here n pages are required for r research notes.

@SidharthBansal
Copy link
Member Author

Added to GCI dashboard

@aashna27
Copy link
Contributor

aashna27 commented Nov 4, 2018

It hasn't still been claimed by any student maybe because they are finding it hard. Should it be simplified ?

@SidharthBansal
Copy link
Member Author

We would be happy if you can help

@oorjitchowdhary
Copy link
Member

Hi.. where can I view the problem and also where is the code file ? Pls share it.. Thanks

@oorjitchowdhary
Copy link
Member

This issue is still open right? I'd like to work on it

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Nov 13, 2018 via email

@oorjitchowdhary
Copy link
Member

Hi.. where can I view the problem and also where is the code file ? Pls share it.. Thanks

@SidharthBansal

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Nov 13, 2018 via email

@oorjitchowdhary
Copy link
Member

@SidharthBansal Oh okay no prblem.. Really sorry to disturb you

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Nov 13, 2018 via email

@oorjitchowdhary
Copy link
Member

Yes yes ... All the best 💯

@oorjitchowdhary
Copy link
Member

Hi.. where can I view the problem and also where is the code file ? Pls share it.. Thanks

@publiclab/mentors where can I find it?

@jywarren
Copy link
Member

Hi, I believe this ends up using this template: https://github.com/publiclab/plots2/blob/master/app/views/notes/_notes.html.erb

To display on this page: https://publiclab.org/research

I hope that helps! Can you upload a screenshot of the page as it is now? I would guess that Sidharth means when viewing just the questions. This might end up being a bit complicated...

@oorjitchowdhary
Copy link
Member

screenshot 19
This is the page as of now

@oorjitchowdhary
Copy link
Member

Hi, I believe this ends up using this template: https://github.com/publiclab/plots2/blob/master/app/views/notes/_notes.html.erb

To display on this page: https://publiclab.org/research

I hope that helps! Can you upload a screenshot of the page as it is now? I would guess that Sidharth means when viewing just the questions. This might end up being a bit complicated...

I couldn't exactly get you

@oorjitchowdhary
Copy link
Member

@SidharthBansal @jywarren Any idea... I really want to solve this

@oorjitchowdhary
Copy link
Member

screenshot 29
When opening publiclab.org/research, it redirects to publiclab.org/dashboard and the pagination here is correct

@kevinzluo
Copy link
Collaborator

@oorjitchowdhary
I believe what @SidharthBansal is referring to is the fact that if you only select some of the options from the dropdown, such as only events, the pagination is broken.
image

For example, once you select events, there are still 173 pages despite there being far fewer items. I think what is happening now is that all items that are not events are being removed while the events still stay on their same pages (like if you click page 173 there is an event from 8 years ago on it).

I think the tasks asks you to fix it so that it paginates correctly, with each page being filled with events.

Hope this helps.

@tsparksh
Copy link
Member

@jywarren, can you check #4026? I think it is indirectly related to this.

@okonek
Copy link
Contributor

okonek commented Nov 24, 2018

Hi, I am a GCI participant and have studied this task for very long. I have to filter the notes in the home controller, but I don't know by which index should I filter which type of note. How can I filter Questions, Events and Comments in the controller during the database query? What are the db indexes for every one of the type? Thanks.

@okonek
Copy link
Contributor

okonek commented Nov 25, 2018

Hi, I have resolved the issue in this PR: #4042 Could you review please?

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Dec 6, 2018

#2258 (comment) correct.
Sorry for late replies. I was busy with my university work.

@grvsachdeva grvsachdeva added help wanted requires help by anyone willing to contribute JavaScript Ruby labels Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted requires help by anyone willing to contribute JavaScript Ruby
Projects
None yet
Development

No branches or pull requests

8 participants