-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include chrome-driver in our docker image #5725
Comments
Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help. |
Would this improve the time it currently is taking to download and install
chrome? This seems to be breaking our builds a lot and driving build time
to 18-24 minutes... pretty wild! But the system tests themselves aren't
accounting for the extra time; it seems to be in downloading and building
Chrome. I'd love a PR for this if it's related! This is a pretty critical
issue for plots2 right now. But even if not related, this sounds cool!
Thanks!
…On Wed, May 15, 2019 at 9:29 AM Álax de Carvalho Alves < ***@***.***> wrote:
Why installing Chrome Driver in our container every Travis build time,
when we could just include this in the Dockerfile, generate a docker a
Docker image and shorten our Travis build time duration.
I'd like to do the same work here that I have suggested in the following:
publiclab/mapknitter#604
<publiclab/mapknitter#604>
publiclab/mapknitter#598
<publiclab/mapknitter#598>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5725?email_source=notifications&email_token=AAAF6J5FKBMZ4NACAEV5DCTPVQFYZA5CNFSM4HNDKAU2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GT5TQEA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J32CLACKUVYZWOIE6TPVQFYZANCNFSM4HNDKAUQ>
.
|
Actually it would reduce the time a lot, because everytime the build downloads chrome-drive. And with this we could make the driver already available in our docker image. Another thing that would reduce is do what I have suggested in publiclab/mapknitter#604. The build time would be shortened to something like a |
After we close publiclab/mapknitter#604 we could get into this. |
Why installing Chrome Driver in our container every Travis build time, when we could just include this in the Dockerfile, generate a docker a Docker image and shorten our Travis build time duration.
I'd like to do the same work here that I have suggested in the following:
publiclab/mapknitter#604
publiclab/mapknitter#598
The text was updated successfully, but these errors were encountered: