-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing required dependencies for Chrome Driver #5751
Conversation
…in our Docker image
40ff731
to
0485b08
Compare
Generated by 🚫 Danger |
@jywarren Could you check this out? |
Hmm, i see:
This is where we've been keeping junit test output. Maybe the changes have affected the relative path, or the timing of creating the |
.travis.yml
Outdated
- docker-compose exec web bash -c "chmod +x /usr/local/bin/chromedriver" | ||
- docker-compose exec web bash -c "CI=TRUE GENERATE_REPORT=true rake test:all" | ||
- docker-compose exec web bash -c "CI=TRUE GENERATE_REPORT=true rails test:system test" | ||
- docker-compose exec web bash -c "CI=TRUE GENERATE_REPORT=true $TASK" | ||
- echo -e '<?xml version="1.0" encoding="UTF-8"?>' > output.xml | ||
- tail -n +2 -q ./test/reports/TEST*.xml >> output.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! I see the reports folder is being deleted on this line - so there may be an ordering thing going on here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jywarren I think I might know what's going on, this command only makes sense when we just ran the system tests right? So since I have split those commands execution it will brake when it runs in normal tests. I'll fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i think that's right. Although junit was originally for regular, not system tests. I honestly don't remember where we put the folder deletion line, but we can probably use search to find it!
5422549
to
a741140
Compare
I think Travis isn't running due to the conflicts? |
Exciting, thanks @alaxalves !!! |
7b86b31
to
95e5dae
Compare
…ue5725-chrome-driver
95e5dae
to
5a61b47
Compare
@jywarren Great news, it's done. Build is taking ~8 minutes to run all tests now. I see that there are other ways to improve our CI/Docker interaction, but this will work well for now. |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
OMG awesome!!!!!! @icarito check this out!!! |
Installing required dependencies for chrome driver and installing it in our docker image.
Fixes #5725 and #5683 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!