Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing required dependencies for Chrome Driver #5751

Merged
merged 3 commits into from
May 22, 2019

Conversation

alaxalves
Copy link
Member

Installing required dependencies for chrome driver and installing it in our docker image.

Fixes #5725 and #5683 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@alaxalves alaxalves changed the title Installing required dependencies for Chrome Driver and installing it … Installing required dependencies for Chrome Driver May 21, 2019
@plotsbot
Copy link
Collaborator

plotsbot commented May 21, 2019

2 Messages
📖 @alaxalves Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@alaxalves
Copy link
Member Author

@jywarren Could you check this out?

@jywarren
Copy link
Member

Hmm, i see:

$ tail -n +2 -q ./test/reports/TEST*.xml >> output.xml
tail: cannot open ‘./test/reports/TEST*.xml’ for reading: No such file or directory

This is where we've been keeping junit test output. Maybe the changes have affected the relative path, or the timing of creating the /reports/ directory?

.travis.yml Outdated
- docker-compose exec web bash -c "chmod +x /usr/local/bin/chromedriver"
- docker-compose exec web bash -c "CI=TRUE GENERATE_REPORT=true rake test:all"
- docker-compose exec web bash -c "CI=TRUE GENERATE_REPORT=true rails test:system test"
- docker-compose exec web bash -c "CI=TRUE GENERATE_REPORT=true $TASK"
- echo -e '<?xml version="1.0" encoding="UTF-8"?>' > output.xml
- tail -n +2 -q ./test/reports/TEST*.xml >> output.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I see the reports folder is being deleted on this line - so there may be an ordering thing going on here:

https://travis-ci.org/publiclab/plots2/jobs/535281058#L5144

Copy link
Member Author

@alaxalves alaxalves May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jywarren I think I might know what's going on, this command only makes sense when we just ran the system tests right? So since I have split those commands execution it will brake when it runs in normal tests. I'll fix that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i think that's right. Although junit was originally for regular, not system tests. I honestly don't remember where we put the folder deletion line, but we can probably use search to find it!

@jywarren
Copy link
Member

I think Travis isn't running due to the conflicts?

@jywarren
Copy link
Member

Exciting, thanks @alaxalves !!!

@alaxalves alaxalves force-pushed the issue5725-chrome-driver branch 3 times, most recently from 7b86b31 to 95e5dae Compare May 22, 2019 02:08
@alaxalves
Copy link
Member Author

Exciting, thanks @alaxalves !!!

@jywarren Great news, it's done. Build is taking ~8 minutes to run all tests now. I see that there are other ways to improve our CI/Docker interaction, but this will work well for now.

@jywarren jywarren merged commit 482d6f3 into publiclab:master May 22, 2019
@welcome
Copy link

welcome bot commented May 22, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

OMG awesome!!!!!! @icarito check this out!!!

@alaxalves alaxalves deleted the issue5725-chrome-driver branch May 22, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include chrome-driver in our docker image
3 participants