Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 503.html #11092

Closed
wants to merge 1 commit into from
Closed

Updated 503.html #11092

wants to merge 1 commit into from

Conversation

Crisoal
Copy link
Contributor

@Crisoal Crisoal commented Apr 22, 2022

changed


to
tag in lines 46 & 62

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

changed <hr/> to <hr> tag in lines 46 & 62
@gitpod-io
Copy link

gitpod-io bot commented Apr 22, 2022

@codeclimate
Copy link

codeclimate bot commented Apr 22, 2022

Code Climate has analyzed commit d38eaaa and detected 0 issues on this pull request.

View more on Code Climate.

@TildaDares
Copy link
Member

Hi @Crisoal, it’s better to open one PR for the changes that are required of you. Can you close the rest PRs and leave this one open? I’ll guide you on how to add the rest changes to this PR.

@Crisoal
Copy link
Contributor Author

Crisoal commented Apr 22, 2022

Hi @Crisoal, it’s better to open one PR for the changes that are required of you. Can you close the rest PRs and leave this one open? I’ll guide you on how to add the rest changes to this PR.

I have closed the other pull requests

@TildaDares
Copy link
Member

@Crisoal I recorded a video of how you're going to edit the remaining files. Go back to the issue you were assigned and check which lines you're supposed to change.

Untitled.mp4

@TildaDares
Copy link
Member

404.html (Line 62)

422.html (Lines 45 and 63)

500.html (Lines 43, 47, 65)

502.html (Lines 46, 62)

503.html (Lines 46, 62)

@Crisoal
Copy link
Contributor Author

Crisoal commented Apr 22, 2022

@Crisoal I recorded a video of how you're going to edit the remaining files. Go back to the issue you were assigned and check which lines you're supposed to change.

Untitled.mp4

ok, thank you

@TildaDares TildaDares mentioned this pull request Apr 22, 2022
5 tasks
@Crisoal Crisoal closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants