Clean up styling of location form #6969
Conversation
nstjean
force-pushed
the
post-location-form
branch
from
69eb544
to
9dc5409
Compare
|
Nice! Is this just code cleanup or UI changes as well?
|
|
Ahh, sorry! This it the form on /post/. Both code cleanup and some very minor UI adjustments.
|
|
This looks good. One idea that could be added - could we make "by entering coordinates" be a link that shows those two inputs, and hide them by default, to make this area visually simpler? And, would you be able to share a screenshot at a mobile device width? You can click the "tablet" icon in the Dev tools console and select a device here:
Thank you! |
|
Sure, I like the idea of hiding the coordinates box by default. :) I'll do
that and then add the screenshots.
|
nstjean
force-pushed
the
post-location-form
branch
from
9dc5409
to
612dcdf
Compare
|
|
|
Yes that makes sense, I was wondering if it was going to be obvious enough for people to know what to do! This ok?
|
|
Awesome!!! Merging!! |
| @@ -0,0 +1,16 @@ | |||
| .leaflet-marker-icon { | |||
| background: url("https://raw.githubusercontent.com/pointhi/leaflet-color-markers/master/img/marker-icon-black.png") ; | |||
There was a problem hiding this comment.
@nstjean, is there a reason behind adding this code? This is currently turning all marker icons' background to black.
There was a problem hiding this comment.
@crisner Looks like I just moved that code from rich.html.rb into a stylesheet. So feel free to remove it if it's causing issues!
There was a problem hiding this comment.
Aha, yes i think this will overwrite LEL css also.
@nstjean , ideally we should make this a functionality in PL.editor to change marker color by taking input from user.
But for now let's move this css back as it may cause issues in future 😄
There was a problem hiding this comment.
Interesting. I don't actually see it changing the marker color in /post/ - I'm wondering if we can just remove it altogether. @crisner where are you seeing the color change?
There was a problem hiding this comment.
Here:https://publiclab.org/map
And here: https://publiclab.org/wiki/unearthing-pvd
I guess wherever we have maps.
There was a problem hiding this comment.
Ahhh, now I see where it is!
Fix in PR #7222
* cleaned up styling of location form * click to show coordinates on form * make entering coordinates link underlined
* cleaned up styling of location form * click to show coordinates on form * make entering coordinates link underlined
Fixes #6968 (<=== Add issue number here)
.form-groupfor spacing items out<label>and<p>in a standard way for each elementlocation.cssTo make the "location privacy here" link open in a new window that will need to be done in
PL.EditorThe "Remove location" button has been added in another PR #6957