-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove styling for leaflet-marker-icon #7222
Conversation
This styling was originally in rich.html.erb for the /post/ location form. The style was causing an issue with some map layers, but wasn't doing anything to the color of the marker in /post/ . |
Codecov Report
@@ Coverage Diff @@
## master #7222 +/- ##
======================================
Coverage 81.5% 81.5%
======================================
Files 97 97
Lines 5602 5602
======================================
Hits 4566 4566
Misses 1036 1036 |
I am not understanding the codecov report. This patch affects 0% of the coverage, but it's showing project is -4.89%? |
Screenshots 📸 (click to expand)7222-test_questions.png7222-test_embeddable_grids.png7222-test_signup.png7222-test_viewing_the_settings_page.png7222-test_tag_by_author_page.png7222-test_wiki_page_with_inline_grids.png7222-test_stats.png7222-test_viewing_the_dashboard.png7222-test_searching_an_item_from_the_homepage.png7222-test_signup_modal_form_validation.png7222-test_tag_stats.png7222-test_questions_shadow.png7222-test_login_modal.png7222-test_profile_page.png7222-test_comments.png7222-test_tags.png7222-test_signup_modal.png7222-test_wiki.png7222-test_methods.png7222-test_tag_page.png7222-test_blog_page_with_location_modal.png7222-test_tag_wildcard.png7222-test_signup_modal_disabled_submit_button_on_empty_username.png7222-test_embeddable_thumbnail_grids.png7222-test_front_page_with_navbar_search_autocomplete.png7222-test_spam_moderation_page.png7222-test_login.png7222-test_viewing_the_dropdown_menu.png7222-test_viewing_question_post.png7222-test_mobile_displays.png7222-test_simple-data-grapher_powertag.png7222-test_front.png7222-test_question_page.png7222-test_tag_contributors_page.png7222-test_blog.png7222-test_people.png7222-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
@jywarren It worked this time! All set to merge. |
Great! I assume @crisner sees this but just cc'ing in case. Thanks! |
Addresses problem mentioned in #6969