Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove styling for leaflet-marker-icon #7222

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

nstjean
Copy link
Contributor

@nstjean nstjean commented Jan 13, 2020

Addresses problem mentioned in #6969

@nstjean
Copy link
Contributor Author

nstjean commented Jan 13, 2020

This styling was originally in rich.html.erb for the /post/ location form. The style was causing an issue with some map layers, but wasn't doing anything to the color of the marker in /post/ .

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #7222 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #7222   +/-   ##
======================================
  Coverage    81.5%   81.5%           
======================================
  Files          97      97           
  Lines        5602    5602           
======================================
  Hits         4566    4566           
  Misses       1036    1036

@nstjean
Copy link
Contributor Author

nstjean commented Jan 13, 2020

I am not understanding the codecov report. This patch affects 0% of the coverage, but it's showing project is -4.89%?

@jywarren
Copy link
Member

Hmm. It's possible there is a problem with it... let's try restarting it. I'll take a screenshot so we can compare once it finishes again.

image

@jywarren jywarren closed this Jan 13, 2020
@jywarren jywarren reopened this Jan 13, 2020
@plotsbot
Copy link
Collaborator

2 Warnings
⚠️ This pull request cannot be merged yet due to merge conflicts. Please resolve them – probably by rebasing – and ask for help (in the comments, or in the chatroom if you get into trouble!.
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @nstjean Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

7222-test_questions.png

7222-test_embeddable_grids.png

7222-test_signup.png

7222-test_viewing_the_settings_page.png

7222-test_tag_by_author_page.png

7222-test_wiki_page_with_inline_grids.png

7222-test_stats.png

7222-test_viewing_the_dashboard.png

7222-test_searching_an_item_from_the_homepage.png

7222-test_signup_modal_form_validation.png

7222-test_tag_stats.png

7222-test_questions_shadow.png

7222-test_login_modal.png

7222-test_profile_page.png

7222-test_comments.png

7222-test_tags.png

7222-test_signup_modal.png

7222-test_wiki.png

7222-test_methods.png

7222-test_tag_page.png

7222-test_blog_page_with_location_modal.png

7222-test_tag_wildcard.png

7222-test_signup_modal_disabled_submit_button_on_empty_username.png

7222-test_embeddable_thumbnail_grids.png

7222-test_front_page_with_navbar_search_autocomplete.png

7222-test_spam_moderation_page.png

7222-test_login.png

7222-test_viewing_the_dropdown_menu.png

7222-test_viewing_question_post.png

7222-test_mobile_displays.png

7222-test_simple-data-grapher_powertag.png

7222-test_front.png

7222-test_question_page.png

7222-test_tag_contributors_page.png

7222-test_blog.png

7222-test_people.png

7222-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

@nstjean
Copy link
Contributor Author

nstjean commented Jan 14, 2020

@jywarren It worked this time! All set to merge.

@jywarren
Copy link
Member

Great! I assume @crisner sees this but just cc'ing in case. Thanks!

@jywarren jywarren merged commit 055677b into publiclab:master Jan 15, 2020
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants