Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zoom override to maps in sidebar and top of page #7078

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Add zoom override to maps in sidebar and top of page #7078

merged 1 commit into from
Jan 2, 2020

Conversation

nstjean
Copy link
Contributor

@nstjean nstjean commented Jan 1, 2020

Fixes #7077 (<=== Add issue number here)

  • This adds in the zoom tag being passed to the map/leaflet partial.
  • If the contents of that tag is empty then it uses the default lat.to_s.length.to_i + 6 as it was using before.

Wiki page that has lat and lon but no zoom tag:

FireShot Capture 152 - 🎈 Public Lab_ Software Outreach - localhost

Wiki page that has lat, lon and zoom tags:

FireShot Capture 153 - 🎈 Public Lab_ Media - localhost

Wiki page that has lat, lon, zoom and place tags:

FireShot Capture 151 - 🎈 Public Lab_ Events - localhost

Note that has lat, lon and zoom tags:

FireShot Capture 154 - 🎈 Public Lab_ Notes on England - localhost

@nstjean nstjean changed the title add zoom option to maps in sidebar and top Add zoom override to maps in sidebar and top of page Jan 1, 2020
@nstjean
Copy link
Contributor Author

nstjean commented Jan 1, 2020

I noticed that after you pan the map a location marker appears. Should the marker show when the map is first loaded? Or it working as intended?

FireShot Capture 156 - 🎈 Public Lab_ Notes on England - localhost

This was referenced Jan 1, 2020
Open
Closed
@jywarren
Copy link
Member

jywarren commented Jan 2, 2020 via email

jywarren
jywarren approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise good to go -- ready to merge then? Thanks!!!!

@nstjean
Copy link
Contributor Author

nstjean commented Jan 2, 2020

Oh ok! Yes this is ready for merge!

@jywarren jywarren merged commit b701668 into publiclab:master Jan 2, 2020
@jywarren
Copy link
Member

jywarren commented Jan 2, 2020

Hooray!

@nstjean nstjean deleted the maps-sidebar branch January 2, 2020 18:19
Tlazypanda pushed a commit to Tlazypanda/plots2 that referenced this pull request Jan 14, 2020
@nstjean @Tlazypanda
add zoom option to maps in sidebar and top (publiclab#7078)
fe49d82
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
@nstjean
add zoom option to maps in sidebar and top (publiclab#7078)
c3b0bd6
@crisner crisner mentioned this pull request Feb 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

@sagarpreet-chadha sagarpreet-chadha Awaiting requested review from sagarpreet-chadha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add zoom override to maps in sidebar and top of page
2 participants
@nstjean @jywarren