Map markers for nodes only appear after map interaction, not on initial load

[jywarren]

Pages like https://publiclab.org/wiki/sandbox-3 show off the great new features of inline maps, but I noticed that the map markers for content (pages on PL) don't appear on initial load; only after interacting with the map a bit:

Initial load (no black map markers):

After dragging map:

I want to guess that the trigger for loading the remote API call for that layer is not triggered on initial page load, only on map move. Or if it is, it's getting missed perhaps due to load order?

@sagarpreet-chadha would you mind taking a look here to see if we can adjust this? Thank you!

[sagarpreet-chadha]

Yes i think i figured why this is happening! I will work on this issue on weekend. Thanks.

…

On Wed, 4 Dec 2019, 20:37 Jeffrey Warren, ***@***.***> wrote: Pages like https://publiclab.org/wiki/sandbox-3 show off the great new features of inline maps, but I noticed that the map markers for content (pages on PL) don't appear on initial load; only after interacting with the map a bit: Initial load: [image: image] <https://user-images.githubusercontent.com/24359/70154003-c7fa1580-167d-11ea-9bbb-2ce0ff93b30b.png> After dragging map: [image: image] <https://user-images.githubusercontent.com/24359/70153969-b9136300-167d-11ea-8700-55c675018f85.png> I want to guess that the trigger for loading the remote API call for that layer is not triggered on initial page load, only on map move. Or if it is, it's getting missed perhaps due to load order? @sagarpreet-chadha <https://github.com/sagarpreet-chadha> would you mind taking a look here to see if we can adjust this? Thank you! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6910?email_source=notifications&email_token=ADSCRRNYOOMTOYHORCZ5PK3QW7BU3A5CNFSM4JVKDE62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6BBW4Q>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSCRRNWRDMPSEMTEGOPRCTQW7BU3ANCNFSM4JVKDE6Q> .

[jywarren]

awesome, thank you Sagarpreet!!!! On Thu, Dec 5, 2019 at 1:44 PM Sagarpreet Chadha <notifications@github.com> wrote:

…

Yes i think i figured why this is happening! I will work on this issue on weekend. Thanks. On Wed, 4 Dec 2019, 20:37 Jeffrey Warren, ***@***.***> wrote: > Pages like https://publiclab.org/wiki/sandbox-3 show off the great new > features of inline maps, but I noticed that the map markers for content > (pages on PL) don't appear on initial load; only after interacting with the > map a bit: > > Initial load: > > [image: image] > < https://user-images.githubusercontent.com/24359/70154003-c7fa1580-167d-11ea-9bbb-2ce0ff93b30b.png > > > After dragging map: > > [image: image] > < https://user-images.githubusercontent.com/24359/70153969-b9136300-167d-11ea-8700-55c675018f85.png > > > I want to guess that the trigger for loading the remote API call for that > layer is not triggered on initial page load, only on map move. Or if it is, > it's getting missed perhaps due to load order? > > @sagarpreet-chadha <https://github.com/sagarpreet-chadha> would you mind > taking a look here to see if we can adjust this? Thank you! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #6910?email_source=notifications&email_token=ADSCRRNYOOMTOYHORCZ5PK3QW7BU3A5CNFSM4JVKDE62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6BBW4Q >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ADSCRRNWRDMPSEMTEGOPRCTQW7BU3ANCNFSM4JVKDE6Q > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6910?email_source=notifications&email_token=AAAF6J4Y3N5OLVQTXQKXIO3QXFDXXA5CNFSM4JVKDE62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGBWW2I#issuecomment-562260841>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J55OW7PCBMDGTA3Q3DQXFDXXANCNFSM4JVKDE6Q> .

[jywarren]

@sagarpreet-chadha @nstjean if you happen to put an eye on this that would be great! I bet it's a one-liner to trigger the markers and we just forgot to do an initial page-load trigger.

[nstjean]

Sure! I bet that's exactly what the issue is. @sagarpreet-chadha you said you had figured it out?

[jywarren]

Just noting here - possible additional issue which we believe is solved, but linking:

• markers don't appear at all now; could be linked to the fix -- version bump LEL 2.1.9 #7299 - this is the LEL bump that was causing testing errors, we talked about default loading
• https://publiclab.org/notes/warren/11-16-2019/mashapaug-pond - example of this in sidebar map

[jywarren]

I think i found the event handlers:

plots2/app/assets/javascripts/leaflet_helper.js

Lines 109 to 140 in 23e83cd

	if(typeof mainLayer !== "undefined" && mainLayer !== ""){
	if(mainLayer === "people"){
	map.on('zoomend' , function () {
	peopleLayerParser(map, markers_hash);
	}) ;
	map.on('moveend' , function () {
	peopleLayerParser(map, markers_hash);
	}) ;
	}
	else if(mainLayer === "content"){
	map.on('zoomend' , function () {
	contentLayerParser(map, markers_hash);
	}) ;
	map.on('moveend' , function () {
	contentLayerParser(map, markers_hash);
	}) ;
	}
	else { // it is a tagname
	map.on('zoomend' , function () {
	contentLayerParser(map, markers_hash, mainLayer);
	}) ;
	map.on('moveend' , function () {
	contentLayerParser(map, markers_hash, mainLayer);
	}) ;
	}
	}

[nstjean]

I can fix this, I had to do something similar on /map/. I'll make a PR