Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag suggestions to show all relevant ones #7338

Merged
merged 16 commits into from
Apr 6, 2020
Merged

Fix tag suggestions to show all relevant ones #7338

merged 16 commits into from
Apr 6, 2020

Conversation

imajit
Copy link
Contributor

@imajit imajit commented Jan 23, 2020

Fixes #7289
The subscriptions page does not give tag suggestions based on tags saved in database .Instead it has hard-coded values .


The current results
Screenshot from 2020-01-24 02-53-48


Changes
Screenshot from 2020-01-24 02-54-20
Instead of fixed values it now shows values by fetching them from database .

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6810e8f). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7338   +/-   ##
=========================================
  Coverage          ?   81.87%           
=========================================
  Files             ?       97           
  Lines             ?     5604           
  Branches          ?        0           
=========================================
  Hits              ?     4588           
  Misses            ?     1016           
  Partials          ?        0
Impacted Files Coverage Δ
app/models/tag.rb 97.48% <50%> (ø)

app/models/tag.rb Outdated Show resolved Hide resolved
app/models/tag.rb Outdated Show resolved Hide resolved
@plotsbot
Copy link
Collaborator

2 Warnings
⚠️ It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @imajit Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

7338-test_questions.png

7338-test_embeddable_grids.png

7338-test_signup.png

7338-test_viewing_the_settings_page.png

7338-test_tag_by_author_page.png

7338-test_wiki_page_with_inline_grids.png

7338-test_stats.png

7338-test_viewing_the_dashboard.png

7338-test_searching_an_item_from_the_homepage.png

7338-test_signup_modal_form_validation.png

7338-test_tag_stats.png

7338-test_login_modal_form_validation.png

7338-test_questions_shadow.png

7338-test_login_modal.png

7338-test_profile_page.png

7338-test_comments.png

7338-test_tags.png

7338-test_signup_modal.png

7338-test_wiki.png

7338-test_methods.png

7338-test_tag_page.png

7338-test_blog_page_with_location_modal.png

7338-test_tag_wildcard.png

7338-test_signup_modal_disabled_submit_button_on_empty_username.png

7338-test_embeddable_thumbnail_grids.png

7338-test_front_page_with_navbar_search_autocomplete.png

7338-test_spam_moderation_page.png

7338-test_login.png

7338-test_viewing_the_dropdown_menu.png

7338-test_viewing_question_post.png

7338-test_mobile_displays.png

7338-test_simple-data-grapher_powertag.png

7338-test_front.png

7338-test_question_page.png

7338-test_tag_contributors_page.png

7338-test_blog.png

7338-test_people.png

7338-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

@imajit
Copy link
Contributor Author

imajit commented Jan 26, 2020

@Uzay-G can you please review this pr

Copy link
Member

@Uzay-G Uzay-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @imajit! Nice use of pluck 👍

@Uzay-G
Copy link
Member

Uzay-G commented Jan 30, 2020

Please be more descriptive in the titles for your pr's. Thanks!

@Uzay-G Uzay-G changed the title Fixes issue #7289 Fix tag suggestions to show all relevant ones Jan 30, 2020
Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 🎉 thanks for working on this @imajit and sorry took so long to get this merged

@cesswairimu cesswairimu merged commit cc00525 into publiclab:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very few suggestions show up for subscription
4 participants