-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tag suggestions to show all relevant ones #7338
Fix tag suggestions to show all relevant ones #7338
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7338 +/- ##
=========================================
Coverage ? 81.87%
=========================================
Files ? 97
Lines ? 5604
Branches ? 0
=========================================
Hits ? 4588
Misses ? 1016
Partials ? 0
|
Screenshots 📸 (click to expand)7338-test_questions.png7338-test_embeddable_grids.png7338-test_signup.png7338-test_viewing_the_settings_page.png7338-test_tag_by_author_page.png7338-test_wiki_page_with_inline_grids.png7338-test_stats.png7338-test_viewing_the_dashboard.png7338-test_searching_an_item_from_the_homepage.png7338-test_signup_modal_form_validation.png7338-test_tag_stats.png7338-test_login_modal_form_validation.png7338-test_questions_shadow.png7338-test_login_modal.png7338-test_profile_page.png7338-test_comments.png7338-test_tags.png7338-test_signup_modal.png7338-test_wiki.png7338-test_methods.png7338-test_tag_page.png7338-test_blog_page_with_location_modal.png7338-test_tag_wildcard.png7338-test_signup_modal_disabled_submit_button_on_empty_username.png7338-test_embeddable_thumbnail_grids.png7338-test_front_page_with_navbar_search_autocomplete.png7338-test_spam_moderation_page.png7338-test_login.png7338-test_viewing_the_dropdown_menu.png7338-test_viewing_question_post.png7338-test_mobile_displays.png7338-test_simple-data-grapher_powertag.png7338-test_front.png7338-test_question_page.png7338-test_tag_contributors_page.png7338-test_blog.png7338-test_people.png7338-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
@Uzay-G can you please review this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @imajit! Nice use of pluck
👍
Please be more descriptive in the titles for your pr's. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic 🎉 thanks for working on this @imajit and sorry took so long to get this merged
Fixes #7289
The subscriptions page does not give tag suggestions based on tags saved in database .Instead it has hard-coded values .
The current results
Changes
Instead of fixed values it now shows values by fetching them from database .