Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh markers on initial page load #7343

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

nstjean
Copy link
Contributor

@nstjean nstjean commented Jan 24, 2020

Fixes #6910 (<=== Add issue number here)

I don't know why the LEL layers aren't showing up at all on my localhost, but this shows on a page refresh that the content markers are behaving as they should be.

Peek 2020-01-24 11-49

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #7343 into master will decrease coverage by 33.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7343       +/-   ##
===========================================
- Coverage   81.86%   48.32%   -33.55%     
===========================================
  Files          97       97               
  Lines        5602     5811      +209     
===========================================
- Hits         4586     2808     -1778     
- Misses       1016     3003     +1987
Impacted Files Coverage Δ
app/models/drupal_content_field_mapper.rb 0% <0%> (-100%) ⬇️
app/mailers/admin_mailer.rb 0% <0%> (-100%) ⬇️
app/mailers/node_mailer.rb 0% <0%> (-100%) ⬇️
app/controllers/talk_controller.rb 0% <0%> (-100%) ⬇️
app/mailers/password_reset_mailer.rb 0% <0%> (-100%) ⬇️
app/models/drupal_content_field_map_editor.rb 0% <0%> (-100%) ⬇️
app/controllers/settings_controller.rb 0% <0%> (-88.89%) ⬇️
app/controllers/features_controller.rb 0% <0%> (-80.71%) ⬇️
app/mailers/welcome_mailer.rb 0% <0%> (-73.34%) ⬇️
lib/utils.rb 30.76% <0%> (-69.24%) ⬇️
... and 45 more

@plotsbot
Copy link
Collaborator

plotsbot commented Jan 28, 2020

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @nstjean Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

7343-test_questions.png

7343-test_embeddable_grids.png

7343-test_signup.png

7343-test_viewing_the_settings_page.png

7343-test_tag_by_author_page.png

7343-test_wiki_page_with_inline_grids.png

7343-test_stats.png

7343-test_viewing_the_dashboard.png

7343-test_searching_an_item_from_the_homepage.png

7343-test_signup_modal_form_validation.png

7343-test_tag_stats.png

7343-test_login_modal_form_validation.png

7343-test_questions_shadow.png

7343-test_login_modal.png

7343-test_profile_page.png

7343-test_comments.png

7343-test_tags.png

7343-test_signup_modal.png

7343-test_wiki.png

7343-test_methods.png

7343-test_tag_page.png

7343-test_blog_page_with_location_modal.png

7343-test_tag_wildcard.png

7343-test_signup_modal_disabled_submit_button_on_empty_username.png

7343-test_embeddable_thumbnail_grids.png

7343-test_front_page_with_navbar_search_autocomplete.png

7343-test_spam_moderation_page.png

7343-test_login.png

7343-test_viewing_the_dropdown_menu.png

7343-test_viewing_question_post.png

7343-test_mobile_displays.png

7343-test_simple-data-grapher_powertag.png

7343-test_front.png

7343-test_question_page.png

7343-test_tag_contributors_page.png

7343-test_blog.png

7343-test_people.png

7343-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

@nstjean
Copy link
Contributor Author

nstjean commented Jan 28, 2020

@jywarren This is ready to go, other than the travis test error that seems unrelated?

@jywarren
Copy link
Member

Awesome! Yeah... annoying system test! Hm. Maybe need to ask for input from vladimir again, but he's hard at work on publiclab/Leaflet.DistortableImage#512

@jywarren jywarren merged commit 027b7c2 into publiclab:master Jan 28, 2020
@jywarren
Copy link
Member

Great!

@nstjean nstjean deleted the load-map-markers branch January 28, 2020 17:28
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
* refresh markers on initial page load

* clean up code for codeclimate
NitinBhasneria pushed a commit to NitinBhasneria/plots2 that referenced this pull request Feb 5, 2020
* refresh markers on initial page load

* clean up code for codeclimate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map markers for nodes only appear after map interaction, not on initial load
3 participants