-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh markers on initial page load #7343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7343 +/- ##
===========================================
- Coverage 81.86% 48.32% -33.55%
===========================================
Files 97 97
Lines 5602 5811 +209
===========================================
- Hits 4586 2808 -1778
- Misses 1016 3003 +1987
|
Screenshots 📸 (click to expand)7343-test_questions.png7343-test_embeddable_grids.png7343-test_signup.png7343-test_viewing_the_settings_page.png7343-test_tag_by_author_page.png7343-test_wiki_page_with_inline_grids.png7343-test_stats.png7343-test_viewing_the_dashboard.png7343-test_searching_an_item_from_the_homepage.png7343-test_signup_modal_form_validation.png7343-test_tag_stats.png7343-test_login_modal_form_validation.png7343-test_questions_shadow.png7343-test_login_modal.png7343-test_profile_page.png7343-test_comments.png7343-test_tags.png7343-test_signup_modal.png7343-test_wiki.png7343-test_methods.png7343-test_tag_page.png7343-test_blog_page_with_location_modal.png7343-test_tag_wildcard.png7343-test_signup_modal_disabled_submit_button_on_empty_username.png7343-test_embeddable_thumbnail_grids.png7343-test_front_page_with_navbar_search_autocomplete.png7343-test_spam_moderation_page.png7343-test_login.png7343-test_viewing_the_dropdown_menu.png7343-test_viewing_question_post.png7343-test_mobile_displays.png7343-test_simple-data-grapher_powertag.png7343-test_front.png7343-test_question_page.png7343-test_tag_contributors_page.png7343-test_blog.png7343-test_people.png7343-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
@jywarren This is ready to go, other than the travis test error that seems unrelated? |
Awesome! Yeah... annoying system test! Hm. Maybe need to ask for input from vladimir again, but he's hard at work on publiclab/Leaflet.DistortableImage#512 |
jywarren
approved these changes
Jan 28, 2020
Great! |
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
* refresh markers on initial page load * clean up code for codeclimate
NitinBhasneria
pushed a commit
to NitinBhasneria/plots2
that referenced
this pull request
Feb 5, 2020
* refresh markers on initial page load * clean up code for codeclimate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6910 (<=== Add issue number here)
I don't know why the LEL layers aren't showing up at all on my localhost, but this shows on a page refresh that the content markers are behaving as they should be.