Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testbench: Add capabilities to add non-idealities to the simulation memory #8

Merged
merged 1 commit into from
Aug 12, 2022
Merged

testbench: Add capabilities to add non-idealities to the simulation memory #8

merged 1 commit into from
Aug 12, 2022

Conversation

thommythomaso
Copy link
Collaborator

No description provided.

@thommythomaso thommythomaso changed the title WIP: Add capabilities to restrict memory testbench: Add capabilities to add non-idealities to the simulation memory Aug 12, 2022
@thommythomaso thommythomaso marked this pull request as ready for review August 12, 2022 08:50
@thommythomaso thommythomaso requested a review from micprog August 12, 2022 08:50
micprog
micprog approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I suggest to externalize the axi throttling into an axi_throttle module (or similar) to avoid code duplication.

@thommythomaso
Copy link
Collaborator Author

LGTM, although I suggest to externalize the axi throttling into an axi_throttle module (or similar) to avoid code duplication.

Done. I created the axi_throttlemodule. Can you have a quick peek at it?

micprog
micprog approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@micprog micprog left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the minor thing noted, thanks for the quick fix!

test/axi_throttle.sv Outdated Show resolved Hide resolved
@thommythomaso thommythomaso merged commit a13c6e6 into master Aug 12, 2022
@thommythomaso thommythomaso deleted the feature/restrict_mem branch August 12, 2022 12:38
@thommythomaso thommythomaso temporarily deployed to github-pages August 12, 2022 12:41 Inactive
@thommythomaso thommythomaso mentioned this pull request Oct 27, 2023
Closed
thommythomaso added a commit that referenced this pull request Oct 27, 2023
@thommythomaso
tracer: Update tracer to the multiprotocol version of iDMA (#8)
a0bc1a9 
* Add a tracer for the DMA #8
thommythomaso added a commit that referenced this pull request Oct 27, 2023
@thommythomaso
tracer: Update tracer to the multiprotocol version of iDMA (#8)
c98e6f1 
* Add a tracer for the DMA #8
thommythomaso added a commit that referenced this pull request Oct 30, 2023
@thommythomaso
tracer: Update tracer to the multiprotocol version of iDMA (#8)
2e173f9 
* Add a tracer for the DMA #8
thommythomaso added a commit that referenced this pull request Oct 30, 2023
@thommythomaso
tracer: Update tracer to the multiprotocol version of iDMA (#8)
28fb85f 
* Add a tracer for the DMA #8
thommythomaso added a commit that referenced this pull request Oct 30, 2023
@thommythomaso
tracer: Update tracer to the multiprotocol version of iDMA (#8)
e3cd418 
* Add a tracer for the DMA #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micprog micprog micprog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thommythomaso @micprog