Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add allow-jit entitlement (fixes Apple Silicon builds) #454

Merged
merged 3 commits into from
Apr 7, 2023

Conversation

meadowsys
Copy link
Member

Apple Silicon macOS builds have been broken since the introduction of second-mate. This is because loading the wasm of vscode-oniguruma fails. As stated in this comment, enabling the com.apple.security.cs.allow-jit entitlement would fix the issue, and it has. I can imagine a not insignificant amount of wasm packages, so if this would be a problem for those, this PR would fix them as well.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super impressive find here, fingers crossed this works as we hope!

@meadowsys
Copy link
Member Author

Might need a few more Apple Silicon users to confirm (test master, test this one), but I have tested it myself using a commit build (on this run, direct dmg download link) and it does seem to fix the issue >w<

@mauricioszabo
Copy link
Contributor

@meadowsys can I, or you, merge back master on this? master is now running the visual tests using the MacOS binaries that we generated, so if Cirrus pass we can say that this issue is fixed :)

@meadowsys
Copy link
Member Author

sure @mauricioszabo you can do it c:

@mauricioszabo
Copy link
Contributor

@meadowsys done, let's see if CI works :)

@mauricioszabo
Copy link
Contributor

@meadowsys here's a timeline:

  1. I merged back master to it, and every build failed
  2. We found that master was also failing on every build, so we went to investigate and found that i18n feature was responsible to breaking builds, so we reverted it
  3. I merged back master to this branch;
  4. Finally, we now are back to green here - full green, including Silicon.

So, can we merge this one?

@meadowsys
Copy link
Member Author

Sounds good, I can merge it

@meadowsys meadowsys merged commit 0413a98 into master Apr 7, 2023
@mauricioszabo mauricioszabo deleted the fix-macos-arm64 branch April 7, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants