-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add allow-jit entitlement (fixes Apple Silicon builds) #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super impressive find here, fingers crossed this works as we hope!
Might need a few more Apple Silicon users to confirm (test master, test this one), but I have tested it myself using a commit build (on this run, direct dmg download link) and it does seem to fix the issue >w< |
@meadowsys can I, or you, merge back |
sure @mauricioszabo you can do it c: |
@meadowsys done, let's see if CI works :) |
@meadowsys here's a timeline:
So, can we merge this one? |
Sounds good, I can merge it |
Apple Silicon macOS builds have been broken since the introduction of
second-mate
. This is because loading the wasm ofvscode-oniguruma
fails. As stated in this comment, enabling thecom.apple.security.cs.allow-jit
entitlement would fix the issue, and it has. I can imagine a not insignificant amount of wasm packages, so if this would be a problem for those, this PR would fix them as well.