Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Renovate #469

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Setup Renovate #469

merged 2 commits into from
Apr 18, 2023

Conversation

confused-Techie
Copy link
Member

This config comes partially from #321 and the renovate docs.

Additionally, this solution was agreed on via a Discord poll. With the one requirement that this is essentially "Read Only". That is, that renovate does not make commits automatically and introduce obscure bugs. This setup will not allow Renovate to submit any PRs or make any automatic changes.

This configuration will only display our dependencies that need updating as a pinned issue on the repo. From there, we could then selective tell Renovate to submit a PR to bump a dep, or we simply use this dashboard as a way to be aware of our dependencies that need to be updated.

I've gone ahead and tried to get this to match our use case as well as possible.

Currently there are a few major sections that will appear in the dashboard:

  • The Editor Dev Dependencies
  • The Editor Dependencies
  • Our Core Package Syntax Theme and UI Theme Dependencies (It seemed like this would be much easier to keep in sync)
  • Our Core Language Packages (Again, the same type of package seems easier to keep in sync)
  • And finally a different section for each of our other packages

With this we could be much more aware of our dependencies, and this could then take on the brunt of responsibility, rather than us needing to identify outdated dependencies all on our own, and call them out in issues automatically.

Resolves #321

NOTE: Again this Renovate Setup Is READ ONLY It will not create any PRs

@confused-Techie
Copy link
Member Author

confused-Techie commented Apr 6, 2023

Alright, and now that tests have come back:

So while this PR really couldn't have introduced any bugs, I think this is a good benchmark for how our failure rate has changed since we last looked at it, and might need to be the updated expectancy rate from here on out, unless of course we are able to get these resolved.

@mauricioszabo
Copy link
Contributor

@confused-Techie honestly, I vote for us to either fix the failing specs (when possible), or rewrite then into the Cypress tool (if posssible), or if everything fails, just comment them. That way, we can instead work on "if CI green, merge" process instead of having to "parse" the failures manually

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly this is a rubber stamp approval.

I am willing to just see if the renovate bot works with this config as intended. If we need to fix something after we have it up and running, having a good config merged makes that iteration easier.

Since this overall move was approved in a poll, I defer the main judgment to that decision-making process that is already completed.

So, yeah, let's go for it. 👍

@confused-Techie confused-Techie merged commit 868f569 into master Apr 18, 2023
@confused-Techie confused-Techie deleted the finally-use-rennovate branch April 18, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Renovate bot running on this repository with a basic config
3 participants