Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add upsert option #118

Merged
merged 2 commits into from
Mar 17, 2021
Merged

feat: Add upsert option #118

merged 2 commits into from
Mar 17, 2021

Conversation

simenandre
Copy link
Contributor

@simenandre simenandre commented Mar 16, 2021

Creates stacks if they don't exists when upsert is set to true.

fixes #90
fixes #9

Creates stacks if they don't exists when `upsert` is set to `true`.

fixes #90
@simenandre simenandre requested a review from stack72 March 16, 2021 20:44
@@ -33,5 +34,6 @@ export async function makeConfig(): Promise<Config> {
githubToken: getInput('github-token'),
commentOnPr: getInput('comment-on-pr') === 'true' ? true : false,
args: getInput('args') || args.join(' '),
upsert: getInput('upsert') === 'true' ? true : false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"false" by default to ensure we maintain backwards compatibility

@stack72 stack72 merged commit 5f678ed into master Mar 17, 2021
@stack72 stack72 deleted the add-upsert branch March 17, 2021 11:39
simenandre added a commit that referenced this pull request Mar 17, 2021
* master:
  ci: Automatically update dist files on every push (#119)
  feat: Add `upsert` option (#118)
  chore(deps-dev): bump eslint-plugin-jest from 24.3.1 to 24.3.2 (#120)
  chore(deps-dev): bump @typescript-eslint/eslint-plugin from 4.17.0 to 4.18.0 (#116)
  chore(deps-dev): bump @typescript-eslint/parser from 4.17.0 to 4.18.0 (#115)
  chore(deps-dev): bump @types/node from 14.14.34 to 14.14.35 (#114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating stacks if they don't exist Add support for Review Pulumi Stacks
2 participants