Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Automatically update dist files on every push #119

Merged
merged 5 commits into from
Mar 17, 2021
Merged

Conversation

simenandre
Copy link
Contributor

@simenandre simenandre commented Mar 16, 2021

fixes #113

The @pulumi-bot comment below is just an example of what would happen if a user creates a pull request where files in dist/ are changed. Would love some opinions on whether we want that comment and what we should write :)

/cc @infin8x @stack72

@simenandre simenandre requested a review from stack72 March 16, 2021 21:19
@pulumi pulumi deleted a comment from github-actions bot Mar 16, 2021
@pulumi pulumi deleted a comment from github-actions bot Mar 16, 2021
@pulumi-bot
Copy link

Hi 👋

Thank you for this contribution!
Due to security reasons, we only allow updating the dist/** files with our own workflows.

@pulumi pulumi deleted a comment from github-actions bot Mar 16, 2021
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just add to the README that the user doesn't need to do anything with the dist/ folder as this is handled internally

@stack72
Copy link
Contributor

stack72 commented Mar 17, 2021

We will need to ensure that yarn build + yarn install is added as part of every test step

@simenandre simenandre merged commit 83390f3 into master Mar 17, 2021
@pulumi-bot pulumi-bot deleted the improve-ci branch March 17, 2021 12:58
simenandre added a commit that referenced this pull request Mar 17, 2021
* master:
  ci: Automatically update dist files on every push (#119)
  feat: Add `upsert` option (#118)
  chore(deps-dev): bump eslint-plugin-jest from 24.3.1 to 24.3.2 (#120)
  chore(deps-dev): bump @typescript-eslint/eslint-plugin from 4.17.0 to 4.18.0 (#116)
  chore(deps-dev): bump @typescript-eslint/parser from 4.17.0 to 4.18.0 (#115)
  chore(deps-dev): bump @types/node from 14.14.34 to 14.14.35 (#114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't accept built dist/ files
3 participants