feat: add option pulumi-version-file
#1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to how [Setup Node](https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md?rgh-link-date=2024-06-24T19%3A12%3A42Z#node-version-file) action works, this adds a new `pulumi-version-file` option that allows users to specify a file to read the version from. A lot of our providers use the `.pulumi.version` file to store the current version of pulumi and we want to be able to use that version rather than relying on what is already installed. re pulumi/ci-mgmt#990
tgummerer
reviewed
Jun 25, 2024
src/config.ts
Outdated
| @@ -22,9 +23,20 @@ export const installationConfig = rt.Record({ | |||
| export type InstallationConfig = rt.Static<typeof installationConfig>; | |||
|
|
|||
| export function makeInstallationConfig(): rt.Result<InstallationConfig> { | |||
| let pulumiVersion = getInput('pulumi-version') || '^3'; | |||
There was a problem hiding this comment.
Should we error out early if both pulumi-version and pulumi-version-file are given?
There was a problem hiding this comment.
Good call! I'll update it.
corymhall
changed the title
pulumi-version-filepulumi-version-file
corymhall
added a commit
that referenced
this pull request
Jun 25, 2024
Update the changelog for a minor release including #1204
corymhall
added a commit
that referenced
this pull request
Jun 25, 2024
Update the changelog for a minor release including #1204
tgummerer
added a commit
that referenced
this pull request
Jul 3, 2024
The pulumi-version-file option was introduced in #1204. However it was only introduced for installation mode, not if a pulumi command is given. The latter has separate config parsing code, so let's introduce the same option there as well.
tgummerer
added a commit
that referenced
this pull request
Jul 11, 2024
* make pulumi-version-file also work in non-install mode The pulumi-version-file option was introduced in #1204. However it was only introduced for installation mode, not if a pulumi command is given. The latter has separate config parsing code, so let's introduce the same option there as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how Setup
Node action works, this adds a new
pulumi-version-fileoption that allows users to specify a file to read the version from.A lot of our providers use the
.pulumi.versionfile to store the current version of pulumi and we want to be able to use that version rather than relying on what is already installed.re pulumi/ci-mgmt#990