make pulumi-version-file also work in non-install mode #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pulumi-version-file option was introduced in #1204. However it was only introduced for installation mode, not if a pulumi command is given. The latter has separate config parsing code, so let's introduce the same option there as well.
tgummerer
force-pushed
the
tg/pulumi-version-file-part-2
branch
from
016ff26
to
781cd44
Compare
|
/cc @corymhall who probably has most context here. I'd appreciate if you could have a quick look! |
corymhall
approved these changes
Jul 3, 2024
justinvp
reviewed
Jul 3, 2024
src/config.ts
Outdated
| @@ -24,6 +24,9 @@ export type InstallationConfig = rt.Static<typeof installationConfig>; | |||
|
|
|||
| export function makeInstallationConfig(): rt.Result<InstallationConfig> { | |||
| let pulumiVersion = getInput('pulumi-version'); | |||
| if (pulumiVersion === "undefined") { | |||
There was a problem hiding this comment.
When will this be the string "undefined"?
There was a problem hiding this comment.
This is an awkward side effect of the way we're testing this. When we're setting up the mocked config here, the "undefined" gets turned into a string. Though maybe we should be using mocks instead for at least the version so we can avoid this 🤔
justinvp
approved these changes
Jul 11, 2024
|
This PR has been shipped in release v5.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pulumi-version-file option was introduced in #1204. However it was only introduced for installation mode, not if a pulumi command is given. The latter has separate config parsing code, so let's introduce the same option there as well.
Fixes: #1215