Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show processing state in printer columns (i.e., in the output of kubectl get stack) #396

Closed
squaremo opened this issue Jan 6, 2023 · 2 comments · Fixed by #747
Closed
Assignees
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@squaremo
Copy link
Contributor

squaremo commented Jan 6, 2023

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

It is hard to see from the outside whether a Stack object is responding to changes you've made. For example, whether it has seen, and is running, new code you've committed. At present, only the last state reached is shown; so if it goes from success to success with a new source revision, you won't see any change.

The obvious way to improve this is to use additionalPrinterColumns so that kubectl get stack will show a summary of the state, including when it's processing. The Ready/Reconciling/Stalled conditions give enough info to show what's happening at the time of asking; they may need to be summarised in a new .status field for it to be usable in additionalPrinterColumns.

The revision under processing would also be useful -- in most cases this will be the last attempted revision, but there may need to be work done to ensure this (and .lastSuccessfulCommit) is kept accurate.

State How to calculate it Revision reported
Ready Condition Ready=True .status.lastUpdate.lastSuccessfulCommit
Retrying Condition Reconciling=True, Reason=RetryingAfterFailure .status.lastUpdate.lastAttemptedCommit
Running Condition Reconciling=True, Reason=Processing needs to be set from locals in Reconcile, I think
Stalled Condition Stalled=True .status.lastUpdate.lastAttemptedCommit
@squaremo squaremo added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jan 6, 2023
@squaremo squaremo removed the needs-triage Needs attention from the triage team label Jan 6, 2023
@EronWright EronWright added the good-first-issue Start here if you'd like to start contributing to Pulumi label Oct 29, 2024
@cleverguy25
Copy link

Added to epic #586

@EronWright
Copy link
Contributor

Related: #393

EronWright added a commit that referenced this issue Nov 11, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
    for Pulumi's contribution guidelines.

    Help us merge your changes more quickly by adding more details such
    as labels, milestones, and reviewers.-->

### Proposed changes

<!--Give us a brief description of what you've done and what it solves.
-->

Updates the printer columns for `Stack` resource to show more information about the status conditions and the latest update.

Note that the "Age" column takes on a different meaning than before; it
was `Stack.metadata.creationTimestamp`, now is the
`.status.lastResyncTime`, to reflect the age of the latest update which
is far more useful for a long-lasting object.

### Related issues (optional)

<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->

Closes #396 
Closes #393
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants