Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show stack processing state in printer columns #747

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Show stack processing state in printer columns #747

merged 2 commits into from
Nov 11, 2024

Conversation

EronWright
Copy link
Contributor

@EronWright EronWright commented Nov 10, 2024 •
edited
Loading

Proposed changes

Note that the "Age" column takes on a different meaning than before; it was Stack.metadata.creationTimestamp, now is the .status.lastResyncTime, to reflect the age of the latest update which is far more useful for a long-lasting object.

Before:

❯ k get stack
NAME          AGE     STATE
outputs       3h51m   succeeded
random-yaml   3d6h    succeeded

After:

❯ k get stack
NAME          LAST UPDATE   AGE     READY   RECONCILING   STALLED   PERMALINK
child-1       succeeded     42s     True                            https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/19
child-2       succeeded     41s     True                            https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/19
outputs       succeeded     17h     True                            https://app.pulumi.com/eron-pulumi-corp/outputs/dev/updates/1
parent        succeeded     50s     True                            https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/20
random-yaml   succeeded     3d19h   True                            https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4901

❯ k get stack
NAME          LAST UPDATE   AGE     READY   RECONCILING       STALLED   PERMALINK
child-1       succeeded     70s     False   StackProcessing             https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/19
child-2       succeeded     69s     False   StackProcessing             https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/19
outputs       succeeded     17h     False   StackProcessing             https://app.pulumi.com/eron-pulumi-corp/outputs/dev/updates/1
parent        succeeded     1s      True                                https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/21
random-yaml   succeeded     3d19h   True                                https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4901

After (wide):

❯ k get stack -owide
NAME          STACK     LAST UPDATE   AGE     LAST COMMIT                                                               READY   RECONCILING   STALLED   PERMALINK
child-1       child-1   succeeded     3s      sha256:7fde601a78b7143ef7366c8929a8599bab0d1183301a5fbc0c94db31d2df002c   True                            https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/24
child-2       child-2   succeeded     3s      sha256:7fde601a78b7143ef7366c8929a8599bab0d1183301a5fbc0c94db31d2df002c   True                            https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/24
parent        parent    succeeded     11s     sha256:7fde601a78b7143ef7366c8929a8599bab0d1183301a5fbc0c94db31d2df002c   True                            https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/25
random-yaml   dev       succeeded     3d19h   sha256:7fde601a78b7143ef7366c8929a8599bab0d1183301a5fbc0c94db31d2df002c   True                            https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4901

After (watch with three dynamic stacks):

❯ k get stack --watch
NAME          LAST UPDATE   AGE     READY   RECONCILING                STALLED   PERMALINK
child-1       succeeded     64s     False   PrerequisiteNotSatisfied             https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/14
child-2       succeeded     64s     False   PrerequisiteNotSatisfied             https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/14
outputs       succeeded     5h12m   True                                         https://app.pulumi.com/eron-pulumi-corp/outputs/dev/updates/1
parent        succeeded     72s     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/14
random-yaml   succeeded     3d7h    True                                         https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4901
parent        succeeded     0s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/15
child-1       succeeded     69s     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/14
child-2       succeeded     69s     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/14
child-1       succeeded     0s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/15
child-2       succeeded     0s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/15
parent        succeeded     68s     True                                         https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/15
child-2       succeeded     60s     False   PrerequisiteNotSatisfied             https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/15
child-1       succeeded     60s     False   PrerequisiteNotSatisfied             https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/15
parent        succeeded     68s     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/15
parent        succeeded     0s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/16
child-1       succeeded     68s     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/15
child-2       succeeded     68s     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/15
child-1       succeeded     1s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/16
child-2       succeeded     1s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/16
parent        succeeded     69s     True                                         https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/16
child-1       succeeded     61s     False   PrerequisiteNotSatisfied             https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/16
child-2       succeeded     61s     False   PrerequisiteNotSatisfied             https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/16
parent        succeeded     69s     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/16
parent        failed        0s      False   RetryingAfterFailure                 
parent        failed        61m     False   StackProcessing                      
parent        succeeded     0s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/18
child-1       succeeded     90m     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/16
child-2       succeeded     90m     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/16
child-1       failed        0s      False   RetryingAfterFailure                 
child-2       failed        0s      False   RetryingAfterFailure                 
parent        succeeded     3h18m   True                                         https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/18
child-1       failed        61m     False   PrerequisiteNotSatisfied             
child-2       failed        61m     False   PrerequisiteNotSatisfied             
parent        succeeded     3h18m   False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/18
parent        succeeded     0s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/19
child-2       failed        6h43m   False   StackProcessing                      
child-1       failed        6h43m   False   StackProcessing                      
child-1       succeeded     0s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/18
child-2       succeeded     0s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/18
parent        succeeded     59m     True                                         https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/19
child-1       succeeded     59m     False   PrerequisiteNotSatisfied             https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/18
parent        succeeded     59m     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/19
child-2       succeeded     59m     False   PrerequisiteNotSatisfied             https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/18
parent        succeeded     0s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/parent/updates/20
child-2       succeeded     90m     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/18
child-1       succeeded     90m     False   StackProcessing                      https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/18
child-1       succeeded     0s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/child-1/updates/19
child-2       succeeded     0s      True                                         https://app.pulumi.com/eron-pulumi-corp/random/child-2/updates/19

Related issues (optional)

Closes #396
Closes #393

@EronWright EronWright requested a review from blampe November 10, 2024 17:37
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.70%. Comparing base (b9aba86) to head (5f0b129).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #747   +/-   ##
=======================================
  Coverage   50.70%   50.70%           
=======================================
  Files          30       30           
  Lines        4171     4171           
=======================================
  Hits         2115     2115           
  Misses       1872     1872           
  Partials      184      184

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blampe
blampe approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@blampe blampe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quality of life improvement!

@EronWright EronWright merged commit 5ef19c9 into master Nov 11, 2024
5 checks passed
@EronWright EronWright deleted the issue-396 branch November 11, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blampe blampe blampe approved these changes

Assignees

@EronWright EronWright

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@EronWright @blampe