Fix attach to enable PULUMI_DEBUG_PROVIDERS #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
commented
Feb 28, 2024
| "github.com/pulumi/providertest/pulumitest/opttest" | ||
| ) | ||
|
|
||
| func TestAttach(t *testing.T) { |
There was a problem hiding this comment.
This is currently failing due to the problem with YAML not supporting PULUMI_DEBUG_PROVIDERS. It should work once pulumi/pulumi#15526 is finalized and propagated to pulumi-yaml
|
I can probably check this in with a test skip until we sort out the dependency, WDYT? |
|
I'm happy with that - seems unlikely to affect any production code |
VenelinMartinov
approved these changes
Feb 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1716 +/- ##
==========================================
- Coverage 59.74% 59.19% -0.55%
==========================================
Files 300 308 +8
Lines 42025 42412 +387
==========================================
- Hits 25109 25107 -2
- Misses 15482 15871 +389
Partials 1434 1434 ☔ View full report in Codecov by Sentry. |
What can this possibly be. |
With these change providers based on Plugin Framework as well as muxed providers that utilize Plugin
Framework for a subset of their resources gain support for the PULUMI_DEBUG_PROVIDERS env var.
For example, this will now work:
# Start an AWS provider process, allowing to attach a debugger
$ pulumi-resource-aws
12345
# Instruct Pulumi to connect to the provider process instead of starting a new one
PULUMI_DEBUG_PROVIDERS=aws:12345 pulumi up
iwahbe
added a commit
that referenced
this pull request
Sep 11, 2024
As part of #2148, this PR removes the duplicate implementation of `pulumigrpc.ResourceProviderServer` copied over from pulumi/pulumi and then modified. This is a post #2258 version of #2195, and is much less invasive. Addressing previous edits in response to #2195 (comment): - #1716: This change accommodated for a previous edit (`ProviderWithContext`) and is no longer necessary. That said, the tests it introduced are still present (and continue to pass), so we are sure this commit did not break the functionality. - #1683: Simply brings DiffConfig into line with pu/pu, which we get for free by not vendoring. - #1047: This is still handled in `provider_server.go`, and is still under test. - #1065: This has already been moved out of this area in #2258, so it is no longer relevant here.
iwahbe
added a commit
that referenced
this pull request
Sep 11, 2024
As part of #2148, this PR removes the duplicate implementation of `pulumigrpc.ResourceProviderServer` copied over from pulumi/pulumi and then modified. This is a post #2258 version of #2195, and is much less invasive. Addressing previous edits in response to #2195 (comment): - #1716: This change accommodated for a previous edit (`ProviderWithContext`) and is no longer necessary. That said, the tests it introduced are still present (and continue to pass), so we are sure this commit did not break the functionality. - #1683: Simply brings DiffConfig into line with pu/pu, which we get for free by not vendoring. - #1047: This is still handled in `provider_server.go`, and is still under test. - #1065: This has already been moved out of this area in #2258, so it is no longer relevant here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a small omission PULUMI_DEBUG_PROVIDERS did not work before this change with providers utilizing Plugin Framework, which includes GCP and AWS. It now works.