Remove vendored plugin server #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of #2148, this PR removes the duplicate implementation of `pulumigrpc.ResourceProviderServer` copied over from pulumi/pulumi and then modified. This is a post #2258 version of #2195, and is much less invasive. Addressing previous edits in response to #2195 (comment): - #1716: This change accommodated for a previous edit (`ProviderWithContext`) and is no longer necessary. That said, the tests it introduced are still present (and continue to pass), so we are sure this commit did not break the functionality. - #1683: Simply brings DiffConfig into line with pu/pu, which we get for free by not vendoring. - #1047: This is still handled in `provider_server.go`, and is still under test. - #1065: This has already been moved out of this area in #2258, so it is no longer relevant here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2410 +/- ##
==========================================
+ Coverage 57.10% 57.65% +0.55%
==========================================
Files 369 369
Lines 50593 50110 -483
==========================================
Hits 28893 28893
+ Misses 20123 19638 -485
- Partials 1577 1579 +2 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
approved these changes
Sep 11, 2024
|
You've hit pulumi/pulumi#14240 |
|
This PR has been shipped in release v3.91.0. |
|
Very nice cleanup here thank you. |
guineveresaenger
added a commit
that referenced
this pull request
Sep 24, 2024
Reverts #2410 --------- Co-authored-by: guineveresaenger <guinevere@pulumi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #2148, this PR removes the duplicate implementation of
pulumigrpc.ResourceProviderServercopied over from pulumi/pulumi and then modified.This is a post #2258 version of #2195, and is much less invasive.
Addressing previous edits in response to
#2195 (comment):
ProviderWithContext) and is no longer necessary. That said, the tests it introduced are still present (and continue to pass), so we are sure this commit did not break the functionality.provider_server.go, and is still under test.