(maint) Raise error when template content is empty #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Throws and error if the content is nil. This fixes a problem
when a template cannot be rendered correctly due to some filesytem
issue.
This was originally seen when config_defaults.yml had a
delte: true set for any of the files.
The error message previously thrown was confusing so this is meant
to throw a better error message.
logicminds
changed the title
glennsarti
reviewed
Oct 21, 2019
| @@ -2,6 +2,7 @@ module PDK | |||
| module Util | |||
| module Filesystem | |||
| def write_file(path, content) | |||
| raise ArgumentError, "#{path} is empty" unless content | |||
There was a problem hiding this comment.
I would probably go a step further here. content is expected to be a string due to the ...encode command later.
An empty string would be a valid content, but a nil value would not.
There was a problem hiding this comment.
Also this should be using the gettext format e.g.
raise PDK::CLI::ExitWithError, _(
'%{message} Rename the file or exclude it from the package ' \
'by adding it to the .pdkignore file in your module.',
) % { message: e.message }
|
See #794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws and error if the content is nil. This fixes a problem
when a template cannot be rendered correctly due to some filesytem
issue.
This was originally seen when config_defaults.yml had a
delte: true set for any of the files.
The error message previously thrown was confusing so this is meant
to throw a better error message.