Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Raise error when template content is empty or nil #794

Merged
merged 1 commit into from
Oct 30, 2019
Merged

(maint) Raise error when template content is empty or nil #794

merged 1 commit into from
Oct 30, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Oct 30, 2019

I can't push to the original PR and I want to ensure that this gets into the upcoming release so I've opened this PR to supercede #782 and address the review left by @glennsarti.

  • Throws and error if the content is nil. This fixes a problem
    when a template cannot be rendered correctly due to some filesytem
    issue.

    This was originally seen when config_defaults.yml had a
    delte: true set for any of the files.

    The error message previously thrown was confusing so this is meant
    to throw a better error message.

@logicminds @rodjek
(maint) Raise error when template content is empty or nil
5267b8b 
  * Throws and error if the content is nil.  This fixes a problem
    when a template cannot be rendered correctly due to some filesytem
    issue.

    This was originally seen when config_defaults.yml had a
      delte: true set for any of the files.

    The error message previously thrown was confusing so this is meant
    to throw a better error message.
@rodjek rodjek added this to the November 2019 milestone Oct 30, 2019
@rodjek rodjek requested a review from a team as a code owner October 30, 2019 02:57
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 91.769% when pulling 5267b8b on rodjek:filesystem_error into 57271d9 on puppetlabs:master.

@rodjek rodjek merged commit cedef59 into puppetlabs:master Oct 30, 2019
@rodjek rodjek deleted the filesystem_error branch October 30, 2019 04:06
@rodjek rodjek mentioned this pull request Oct 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennsarti glennsarti glennsarti approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.
5 participants
@rodjek @coveralls @glennsarti @chelnak @logicminds