(MODULES-4973) rip out data in modules #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eputnam
force-pushed
the
remove_dim
branch
2 times, most recently
from
dcc68df to
030520d
Compare
this module is not able to find a value for `$keyserver` when it is included in postgresql, as stated in the ticket. this changes the module back to using the params.pp model. we can revisit data in modules once LTS moves up from 4.7.0. for now, we need the compatibility.
hunner
added a commit
that referenced
this pull request
May 25, 2017
this module is not able to find a value for `$keyserver` when it is included in postgresql, as stated in the ticket. this changes the module back to using the params.pp model. we can revisit data in modules once LTS moves up from 4.7.0. for now, we need the compatibility.
SergK
added a commit
to SergK/puppetlabs-rabbitmq
that referenced
this pull request
May 29, 2017
Latest changes in puppetlabs-apt master branch [1] breaks current CI. This change fixes CI by pinning puppetlabs-apt to tag: 4.0.0 [1]. puppetlabs/puppetlabs-apt#680
kenyon
added a commit
to kenyon/puppetlabs-apt
that referenced
this pull request
Apr 9, 2024
params.pp and create_resources() are obsolete. This module was converted to non-params.pp style puppetlabs#667, but was reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the preferred styles these days.
kenyon
added a commit
to kenyon/puppetlabs-apt
that referenced
this pull request
Apr 9, 2024
params.pp and create_resources() are obsolete. This module was converted to non-params.pp style puppetlabs#667, but was reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the preferred styles these days.
kenyon
added a commit
to kenyon/puppetlabs-apt
that referenced
this pull request
Apr 9, 2024
params.pp and create_resources() are obsolete. This module was converted to non-params.pp style puppetlabs#667, but was reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the preferred styles these days.
kenyon
added a commit
to kenyon/puppetlabs-apt
that referenced
this pull request
Apr 9, 2024
params.pp and create_resources() are obsolete. This module was converted to non-params.pp style puppetlabs#667, but was reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the preferred styles these days.
jamesps-ebi
added a commit
to jps-help/puppetlabs-apt
that referenced
this pull request
Aug 1, 2024
eliminate params.pp and create_resources() params.pp and create_resources() are obsolete. This module was converted to non-params.pp style puppetlabs#667, but was reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the preferred styles these days.
jamesps-ebi
added a commit
to jps-help/puppetlabs-apt
that referenced
this pull request
Nov 18, 2024
eliminate params.pp and create_resources() params.pp and create_resources() are obsolete. This module was converted to non-params.pp style puppetlabs#667, but was reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the preferred styles these days.
jamesps-ebi
added a commit
to jps-help/puppetlabs-apt
that referenced
this pull request
Nov 20, 2024
eliminate params.pp and create_resources() params.pp and create_resources() are obsolete. This module was converted to non-params.pp style puppetlabs#667, but was reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the preferred styles these days.
malikparvez
pushed a commit
to jps-help/puppetlabs-apt
that referenced
this pull request
Nov 25, 2024
eliminate params.pp and create_resources() params.pp and create_resources() are obsolete. This module was converted to non-params.pp style puppetlabs#667, but was reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the preferred styles these days.
amitkarsale
pushed a commit
to jps-help/puppetlabs-apt
that referenced
this pull request
Nov 27, 2024
eliminate params.pp and create_resources() params.pp and create_resources() are obsolete. This module was converted to non-params.pp style puppetlabs#667, but was reverted in puppetlabs#680. Using Hiera in modules and no params.pp are the preferred styles these days.
malikparvez
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Initial testing for deb822 APT sources * Added defined type for generating deb822 apt sources Should be roughly drop-in alternative to the existing apt::source type Does not currently support inline ascii gpg key * Add puppet strings documentation * Replace example with generic content * Initial testing of apt::source with deb822 support * Fix setting_type and signed_by Use 'sources' instead of 'source' as the setting_type parsed to apt::setting Fix the data type of apt::source::signed_by * Fix source_deb822.epp template Correctly handle newline/whitespace trimming for `signed_by` parameter. * Remove link from components to repos * Add logic for deb822 sources * Update documentation for deb822 sources * Update source_format parameter Match the possible values to the file suffix of the created source files. * Add forward-compatibility with deb822 Allow array values for certain parameters to allow easy switching between .list and .sources formats. * Add backward-compatibility for deb822 sources Convert string values to arrays where possible and warn the user. * Fix logic * Revert "Add forward-compatibility with deb822" This reverts commit 9d88e93. * Fix deb822 backward compatibility Correctly compare data type when generating deb822 sources Remove unused class parameters and descriptions * Update puppet-strings and logic Remove references to unused deb822 parameters Update parameter descriptions Update deb822 example Update warnings for $pin and $key usage with deb822. Currently unsupported Don't fail if $location is missing unless $ensure is 'present' * Remove unused spec test * Add unit testing for deb822 sources * Update README.md with deb822 sources example * Fix unit test syntax * Re-apply commit 2faa817 eliminate params.pp and create_resources() params.pp and create_resources() are obsolete. This module was converted to non-params.pp style #667, but was reverted in #680. Using Hiera in modules and no params.pp are the preferred styles these days. * Update apt::config_files hash Add support for deb822 .sources files * Update data types and documentation Re-apply data-type changes for apt::source::pin from 1e1baad Regenerate puppet strings to match. * Update source_deb822.epp template Remove leading whitespace * Update manifests/setting.pp Simplify apt::setting logic Co-authored-by: Tim Meusel <tim@bastelfreak.de> --------- Co-authored-by: James Paton-Smith <jamesps@ebi.ac.uk> Co-authored-by: Tim Meusel <tim@bastelfreak.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this module is not able to find a value for
$keyserverwhen it isincluded in postgresql, as stated in the ticket. this changes the module
back to using the params.pp model. we can revisit data in modules once
LTS moves up from 4.7.0. for now, we need the compatibility.