Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 16.04 to list of distributions that should use software-properties-common. #696

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Add 16.04 to list of distributions that should use software-properties-common. #696

merged 1 commit into from
Sep 25, 2017

Conversation

trevorrea
Copy link

As discussed on Slack with Eric Puttnam this looks to have been accidentally been removed.

Thanks,
Trevor

@hunner
Copy link

hunner commented Aug 25, 2017

This appears to have been an unintentional change introduced in #667 and perpetuated in #680 and we do not acceptance test apt::ppa to catch this.

@trevorrea
Copy link
Author

Thanks @hunner - can this be merged as is or do I need to write tests?

@tphoney tphoney merged commit 616df9d into puppetlabs:master Sep 25, 2017
@tphoney
Copy link

tphoney commented Sep 25, 2017

Thanks for the PR !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trevorrea @hunner @tphoney @Ramesh7