Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include apt in apt::backports #891

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Conversation

zivis
Copy link

@zivis zivis commented Nov 6, 2019

we had issues with the order apt and apt::backports were evaluated.
Even if we have both in catalog.
like:

Evaluation Error: Operator '[]' is not applicable to an Undef Value. (file: /etc/puppetlabs/code/environments/production/modules/apt/manifests/backports.pp, line: 73, column: 18) on node

@zivis zivis requested a review from a team as a code owner November 6, 2019 13:55
@sheenaajay
Copy link

@zivis Thanks for submitting the PR. Could you please take a look into the travis failures. Thank you.

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@bea6af8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #891   +/-   ##
=========================================
  Coverage          ?   73.07%           
=========================================
  Files             ?        5           
  Lines             ?      260           
  Branches          ?        0           
=========================================
  Hits              ?      190           
  Misses            ?       70           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea6af8...d7b00b1. Read the comment docs.

@zivis
Copy link
Author

zivis commented Dec 4, 2019

@sheenaajay it works with the changes from #894
the travis error were all about apt::key
Error: Execution of '/usr/bin/apt-key adv --no-tty --keyserver pool.sks-keyservers.net --recv-keys 6F6B15509CF8E59E6E469F327F438280EF8D349F' returned 2: Executing: gpg --ignore-time-conflict --no-options --no-default-keyring --homedir /tmp/tmp.BXPq3x33eS --no-auto-check-trustdb --trust-model always --keyring /etc/apt/trusted.gpg --primary-keyring /etc/apt/trusted.gpg --keyring /etc/apt/trusted.gpg.d/debian-archive-jessie-automatic.gpg --keyring /etc/apt/trusted.gpg.d/debian-archive-jessie-security-automatic.gpg --keyring /etc/apt/trusted.gpg.d/debian-archive-jessie-stable.gpg --keyring /etc/apt/trusted.gpg.d/debian-archive-stretch-automatic.gpg --keyring /etc/apt/trusted.gpg.d/debian-archive-stretch-security-automatic.gpg --keyring /etc/apt/trusted.gpg.d/debian-archive-stretch-stable.gpg --keyring /etc/apt/trusted.gpg.d/debian-archive-wheezy-automatic.gpg --keyring /etc/apt/trusted.gpg.d/debian-archive-wheezy-stable.gpg --keyring /etc/apt/trusted.gpg.d/puppet5-keyring.gpg --no-tty --keyserver pool.sks-keyservers.net --recv-keys 6F6B15509CF8E59E6E469F327F438280EF8D349F gpg: requesting key EF8D349F from hkp server pool.sks-keyservers.net gpgkeys: key 6F6B15509CF8E59E6E469F327F438280EF8D349F can't be retrieved gpg: no valid OpenPGP data found. gpg: Total number processed: 0

@zivis
Copy link
Author

zivis commented Dec 4, 2019

after #894 is merged, i can rebase this branch again.
here's the link to the succesful travis-build with changes from #894 cherry-picked https://travis-ci.org/puppetlabs/puppetlabs-apt/builds/620632750?utm_medium=notification&utm_source=github_status

@sheenaajay
Copy link

Hi @zivis #894 is merged. Could you please rebase with the master to fix the Travis error. Thank you.

Otherwise there can be issues with undef values.
like:

Evaluation Error: Operator '[]' is not applicable to an Undef Value. (file: /etc/puppetlabs/code/environments/production/modules/apt/manifests/backports.pp, line: 73, column: 18) on node …
@zivis
Copy link
Author

zivis commented Dec 9, 2019

thanks for notifying, now travis builds without any errors :)

@sheenaajay sheenaajay merged commit 81ae72d into puppetlabs:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants