Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULES-10063, extend apt::key to support deeplinks, this time with f… #894

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

kaessert
Copy link

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #894 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files           5        5           
  Lines         260      260           
=======================================
  Hits          190      190           
  Misses         70       70
Impacted Files Coverage Δ
lib/puppet/type/apt_key.rb 96.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b149565...cfd3d35. Read the comment docs.

@sheenaajay
Copy link

@atarax Thanks for submitting the PR.

@sheenaajay
Copy link

The changes are already merged with this PR https://github.com/puppetlabs/puppetlabs-apt/pull/892/files

Could you please take a look and let us know if you are happy with the change and we close the PR.Thank you.

@kaessert
Copy link
Author

kaessert commented Dec 5, 2019

@sheenaajay this PR was also from me https://github.com/puppetlabs/puppetlabs-apt/pull/892/files, however, notice the slight difference of the dot in the regex. with my previous PR, this was not possible:
https://foo.bar/some.key
only
https://foo.bar/somekey

@sheenaajay sheenaajay merged commit bea6af8 into puppetlabs:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants