Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-38817) Adding docs for add replica #477

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

ragingra
Copy link
Member

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed


### `token_file`

- **Type:** `Optional[String]`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe change this to Stdlib::Absolutepath instead of string?

Copy link
Contributor

@CoMfUcIoS CoMfUcIoS Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we need an absolute path here then yes we should.


### `primary_postgresql_host`

- **Type:** `Optional[Peadm::SingleTargetSpec]`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we could get this from getpeadmconfig and remove the param?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, raise a ticket for this.

@ragingra ragingra marked this pull request as ready for review September 2, 2024 12:38
@ragingra ragingra requested review from a team as code owners September 2, 2024 12:38
@CoMfUcIoS CoMfUcIoS merged commit 02365a9 into add_replica_supported Sep 2, 2024
2 checks passed
@CoMfUcIoS CoMfUcIoS deleted the PE-38817 branch September 2, 2024 13:03
CoMfUcIoS pushed a commit that referenced this pull request Sep 2, 2024
Co-authored-by: Neil Anderson <neil.anderson@perforce.com>
CoMfUcIoS pushed a commit that referenced this pull request Sep 10, 2024
Co-authored-by: Neil Anderson <neil.anderson@perforce.com>
CoMfUcIoS pushed a commit that referenced this pull request Sep 12, 2024
Co-authored-by: Neil Anderson <neil.anderson@perforce.com>
CoMfUcIoS added a commit that referenced this pull request Sep 12, 2024
* PE-38815 add_replica plan updated, test matrix added (#480)

* (PE-38818) Removing experimental and private from add_replica (#478)

* (PE-38818) Removing experimental and private from add_replica

* Updating Reference.md

---------

Co-authored-by: Neil Anderson <neil.anderson@perforce.com>

* (PE-38817) Adding docs for add replica (#477)

Co-authored-by: Neil Anderson <neil.anderson@perforce.com>

* chore: update test-add-replica workflow

- Remove unnecessary quotes from YAML keys and values
- Standardize single quotes for string values
- Improve readability by removing extra blank lines

* feat(workflows): add console password to test-add-replica-matrix job

- Included `console_password` parameter in the test-add-replica-matrix job.
- Utilizes `${{ secrets.CONSOLE_PASSWORD }}` for secure password management.

* (PE-38817) Text fixes for add_replica docs (#496)

* PE-39228 add_replica smoke test (#497)

* PE-39228 Smoke test created and added to workflow

* PE-39228 Workflow updated

* PE-39228 Spec updated, smoke test added to matrix

* PE-39228 Versions updated, push trigger removed from matrix

* PE-39228 whitespace fixed

* chore(workflow): update test-add-replica-matrix to use single version

- Removed version `2021.7.9` from the matrix, leaving only `2023.8.0`.

This change simplifies the testing matrix by focusing on the latest version.

* chore(workflow): update test-add-replica-matrix to use single version

- Changed `version` matrix to use an array with only `2023.8.0`.

This change simplifies the testing matrix by focusing on the latest version.

* docs: update REFERENCE.md to use asterisks for list items

- Changed list item markers from hyphens to asterisks for consistency.
- Ensured all list items in the document follow the same format.

* add_replica docs updated

---------

Co-authored-by: Neil Anderson <ragingra@users.noreply.github.com>
Co-authored-by: Neil Anderson <neil.anderson@perforce.com>
Co-authored-by: Aaron Shannon <aaron.shannon@puppet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants