PE-38815 add_replica plan updated, test matrix added #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Aug 22, 2024
| echo ::group::info:request | ||
| cat request.json || true; echo | ||
| echo ::endgroup:: | ||
| fi |
There was a problem hiding this comment.
Can you please add the missing \n in line 124? Otherwise the git diff will look a bit suboptimal when another line is added in the future.
There was a problem hiding this comment.
New line added
|
Test matrix passing here https://github.com/puppetlabs/puppetlabs-peadm/actions/runs/10579356787 |
|
Updated matrix passing here: |
bastelfreak
reviewed
Aug 28, 2024
| server_b_host => $replica_avail_group_letter ? { 'B' => $replica_host, default => undef }, | ||
| internal_compiler_a_pool_address => $replica_avail_group_letter ? { 'A' => $replica_host, default => undef }, | ||
| internal_compiler_b_pool_address => $replica_avail_group_letter ? { 'B' => $replica_host, default => undef }, | ||
| server_a_host => $replica_avail_group_letter ? { 'A' => $replica_target.peadm::certname(), default => undef }, |
There was a problem hiding this comment.
At the top this plan still has:
# This plan is still in development and currently considered experimental.
#
# @api private
is that still the case?
There was a problem hiding this comment.
This is being removed in the below PR:
CoMfUcIoS
added a commit
that referenced
this pull request
Sep 2, 2024
CoMfUcIoS
added a commit
that referenced
this pull request
Sep 10, 2024
CoMfUcIoS
added a commit
that referenced
this pull request
Sep 12, 2024
CoMfUcIoS
added a commit
that referenced
this pull request
Sep 12, 2024
* PE-38815 add_replica plan updated, test matrix added (#480) * (PE-38818) Removing experimental and private from add_replica (#478) * (PE-38818) Removing experimental and private from add_replica * Updating Reference.md --------- Co-authored-by: Neil Anderson <neil.anderson@perforce.com> * (PE-38817) Adding docs for add replica (#477) Co-authored-by: Neil Anderson <neil.anderson@perforce.com> * chore: update test-add-replica workflow - Remove unnecessary quotes from YAML keys and values - Standardize single quotes for string values - Improve readability by removing extra blank lines * feat(workflows): add console password to test-add-replica-matrix job - Included `console_password` parameter in the test-add-replica-matrix job. - Utilizes `${{ secrets.CONSOLE_PASSWORD }}` for secure password management. * (PE-38817) Text fixes for add_replica docs (#496) * PE-39228 add_replica smoke test (#497) * PE-39228 Smoke test created and added to workflow * PE-39228 Workflow updated * PE-39228 Spec updated, smoke test added to matrix * PE-39228 Versions updated, push trigger removed from matrix * PE-39228 whitespace fixed * chore(workflow): update test-add-replica-matrix to use single version - Removed version `2021.7.9` from the matrix, leaving only `2023.8.0`. This change simplifies the testing matrix by focusing on the latest version. * chore(workflow): update test-add-replica-matrix to use single version - Changed `version` matrix to use an array with only `2023.8.0`. This change simplifies the testing matrix by focusing on the latest version. * docs: update REFERENCE.md to use asterisks for list items - Changed list item markers from hyphens to asterisks for consistency. - Ensured all list items in the document follow the same format. * add_replica docs updated --------- Co-authored-by: Neil Anderson <ragingra@users.noreply.github.com> Co-authored-by: Neil Anderson <neil.anderson@perforce.com> Co-authored-by: Aaron Shannon <aaron.shannon@puppet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add_replica plan updated with correct certname passed to update_classification plan, test matrix added
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
Changes include test coverage?
Have you updated the documentation?